New issue
Advanced search Search tips

Issue 690081 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename JavaScript "Messages" to "Dialogs"

Project Member Reported by a...@chromium.org, Feb 8 2017

Issue description

They're dialogs, and the naming obscures it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/777ff4555115c5fa24f6a3125c6a4812b36aca36

commit 777ff4555115c5fa24f6a3125c6a4812b36aca36
Author: avi <avi@chromium.org>
Date: Thu Feb 09 19:04:48 2017

Rename JavaScript "messages" to "dialogs".

BUG= 690081 
TEST=no user-visible changes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2684093002
Cr-Commit-Position: refs/heads/master@{#449367}

[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/android_webview/browser/aw_contents_client_bridge_base.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/android_webview/browser/aw_javascript_dialog_manager.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/android_webview/browser/aw_javascript_dialog_manager.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/android_webview/native/aw_contents_client_bridge.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/android_webview/native/aw_contents_client_bridge.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_mac.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/chrome/browser/ui/javascript_dialogs/javascript_dialog_views.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/components/app_modal/javascript_app_modal_dialog.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/components/app_modal/javascript_app_modal_dialog.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/components/app_modal/javascript_dialog_manager.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/components/app_modal/javascript_dialog_manager.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/components/app_modal/views/javascript_app_modal_dialog_views.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/common/frame_messages.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/public/browser/javascript_dialog_manager.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/public/common/BUILD.gn
[add] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/public/common/javascript_dialog_type.h
[delete] https://crrev.com/99585eb561ed16d0389b3364f689238dd3a6e445/content/public/common/javascript_message_type.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/renderer/render_frame_impl.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/layout_test/layout_test_javascript_dialog_manager.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/shell_javascript_dialog.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/shell_javascript_dialog_mac.mm
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/shell_javascript_dialog_manager.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/shell_javascript_dialog_manager.h
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/content/shell/browser/shell_javascript_dialog_win.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
[modify] https://crrev.com/777ff4555115c5fa24f6a3125c6a4812b36aca36/extensions/browser/guest_view/web_view/javascript_dialog_helper.h

Comment 2 by a...@chromium.org, Feb 9 2017

Status: Fixed (was: Started)

Sign in to add a comment