Issue metadata
Sign in to add a comment
|
Download not auto resuming after clicking pause/resume button |
||||||||||||||||||||
Issue descriptionThis happens on M57 Steps to reproduce: (1) Download a large file (2) While downloading, kill chrome by swiping it away (3) Click pause and then click resume button on notification (4) Download will resume (5) relaunch Chrome, then kill it again, download is now in a pending state (6) relaunch Chrome again, Expected result: download should auto resume after 10 seconds Actual result: Download never resumes.
,
Feb 9 2017
yes, should be the same
,
Feb 9 2017
Issue 689458 has been merged into this issue.
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bd7014090760813fb68a78a03d4ff90803cdffc commit 5bd7014090760813fb68a78a03d4ff90803cdffc Author: qinmin <qinmin@chromium.org> Date: Fri Feb 10 02:08:03 2017 Make all member variables in DownloadNotificationService final Some of the member variables are not final in DNS. This allows another class to modify those variables without DNS knowing it. As a result, such modifications is not written into the SharedPreferences. To address this, other classes should make a new DownloadSharedPreferenceEntry and call AddOrReplace function to inform DNS about the modification. BUG= 690080 Review-Url: https://codereview.chromium.org/2679933005 Cr-Commit-Position: refs/heads/master@{#449513} [modify] https://crrev.com/5bd7014090760813fb68a78a03d4ff90803cdffc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/5bd7014090760813fb68a78a03d4ff90803cdffc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
,
Feb 10 2017
,
Feb 10 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5010a4817336dfc3290463c114a2691352d5466 commit e5010a4817336dfc3290463c114a2691352d5466 Author: Min Qin <qinmin@chromium.org> Date: Fri Feb 10 20:42:53 2017 Make all member variables in DownloadNotificationService final Some of the member variables are not final in DNS. This allows another class to modify those variables without DNS knowing it. As a result, such modifications is not written into the SharedPreferences. To address this, other classes should make a new DownloadSharedPreferenceEntry and call AddOrReplace function to inform DNS about the modification. TBR=dfalcantara@chromium.org BUG= 690080 Review-Url: https://codereview.chromium.org/2679933005 Cr-Commit-Position: refs/heads/master@{#449513} (cherry picked from commit 5bd7014090760813fb68a78a03d4ff90803cdffc) Review-Url: https://codereview.chromium.org/2688243002 . Cr-Commit-Position: refs/branch-heads/2987@{#450} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/e5010a4817336dfc3290463c114a2691352d5466/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
,
Feb 10 2017
,
Feb 15 2017
Works as per expected behavior, Verified on Latest M58 Build.
,
Apr 27 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dfalcant...@chromium.org
, Feb 9 2017