New issue
Advanced search Search tips

Issue 690075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Remove unused strings in Chrome

Project Member Reported by ma...@chromium.org, Feb 8 2017

Issue description

Across all platforms, some strings are sitting in grd(p) files and are not actually used.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1cc2ba3728c23060a2a313e4d705eb5af108076

commit d1cc2ba3728c23060a2a313e4d705eb5af108076
Author: mathp <mathp@chromium.org>
Date: Wed Feb 08 18:31:13 2017

[Autofill] Remove unused strings in autofill_strings.grdp

BUG= 690075 
TEST=builds on all platforms

Review-Url: https://codereview.chromium.org/2681033005
Cr-Commit-Position: refs/heads/master@{#449039}

[modify] https://crrev.com/d1cc2ba3728c23060a2a313e4d705eb5af108076/components/autofill_strings.grdp

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96b843574c741967951a158ccf924b453c3f301a

commit 96b843574c741967951a158ccf924b453c3f301a
Author: mathp <mathp@chromium.org>
Date: Wed Feb 08 23:30:31 2017

[Translate] Remove unused strings from components/translate_strings.grdp

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2684103002
Cr-Commit-Position: refs/heads/master@{#449138}

[modify] https://crrev.com/96b843574c741967951a158ccf924b453c3f301a/components/translate_strings.grdp

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc894276d35816ba9051b8ab382fcd1022a8f0a9

commit cc894276d35816ba9051b8ab382fcd1022a8f0a9
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 12:54:29 2017

[Browsing Data] Remove unused strings in components

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2681253002
Cr-Commit-Position: refs/heads/master@{#449270}

[modify] https://crrev.com/cc894276d35816ba9051b8ab382fcd1022a8f0a9/components/browsing_data_strings.grdp

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca9601da70e57a46a5b37e5aa9b04dc2879dbcb8

commit ca9601da70e57a46a5b37e5aa9b04dc2879dbcb8
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 12:55:46 2017

[Bookmark] Remove unused strings in components

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2680843009
Cr-Commit-Position: refs/heads/master@{#449271}

[modify] https://crrev.com/ca9601da70e57a46a5b37e5aa9b04dc2879dbcb8/components/bookmark_component_strings.grdp

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baaeb3f30ee2984a947fa789288178099838e188

commit baaeb3f30ee2984a947fa789288178099838e188
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 12:57:03 2017

[Flags UI] Remove unused strings from components

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2682223002
Cr-Commit-Position: refs/heads/master@{#449272}

[modify] https://crrev.com/baaeb3f30ee2984a947fa789288178099838e188/components/flags_ui_strings.grdp

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d85d0cea9a4b4921db5ffb64e82fc809f6468d

commit c6d85d0cea9a4b4921db5ffb64e82fc809f6468d
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 16:12:23 2017

[Error Pages] Remove unused strings from components

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2684693005
Cr-Commit-Position: refs/heads/master@{#449306}

[modify] https://crrev.com/c6d85d0cea9a4b4921db5ffb64e82fc809f6468d/components/error_page_strings.grdp

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b74c2d77dc4e670f783e68081141298acb4c642

commit 0b74c2d77dc4e670f783e68081141298acb4c642
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 18:12:02 2017

[Resources] Remove unused strings in chrome/app/generated_resources.grd

Determined and removed by a script.

BUG= 690075 
TEST=builds
TBR=grt

Review-Url: https://codereview.chromium.org/2685133002
Cr-Commit-Position: refs/heads/master@{#449351}

[modify] https://crrev.com/0b74c2d77dc4e670f783e68081141298acb4c642/chrome/app/generated_resources.grd

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cccef482caeea883a603a4467b57314874f4581

commit 9cccef482caeea883a603a4467b57314874f4581
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 18:17:58 2017

[SSL] Remove unused strings in components

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2680203006
Cr-Commit-Position: refs/heads/master@{#449353}

[modify] https://crrev.com/9cccef482caeea883a603a4467b57314874f4581/components/ssl_errors_strings.grdp

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/145325203534c94394bcb6966851486b8fcd29e8

commit 145325203534c94394bcb6966851486b8fcd29e8
Author: mathp <mathp@chromium.org>
Date: Thu Feb 09 20:48:34 2017

[Ash] Remove unused strings from ash/ash_strings.grd

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2682863004
Cr-Commit-Position: refs/heads/master@{#449401}

[modify] https://crrev.com/145325203534c94394bcb6966851486b8fcd29e8/ash/ash_strings.grd

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a25f4dfb17a80bf34678a29bee5f107fba37a84d

commit a25f4dfb17a80bf34678a29bee5f107fba37a84d
Author: mathp <mathp@chromium.org>
Date: Fri Feb 10 23:29:49 2017

[Dom Distiller] Remove unused strings from components

BUG= 690075 
TEST=build

Review-Url: https://codereview.chromium.org/2680153006
Cr-Commit-Position: refs/heads/master@{#449784}

[modify] https://crrev.com/a25f4dfb17a80bf34678a29bee5f107fba37a84d/components/dom_distiller_strings.grdp

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d402a56f17a6d790d92607c66580720e2cdf94ba

commit d402a56f17a6d790d92607c66580720e2cdf94ba
Author: mathp <mathp@chromium.org>
Date: Mon Feb 13 15:30:42 2017

[Policy] Remove unused strings in components

BUG= 690075 
TEST=builds
TBR=atwilson

Review-Url: https://codereview.chromium.org/2683073002
Cr-Commit-Position: refs/heads/master@{#449963}

[modify] https://crrev.com/d402a56f17a6d790d92607c66580720e2cdf94ba/components/policy_strings.grdp

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46445b7459ec3f31ee268d6067bce5ea2e721144

commit 46445b7459ec3f31ee268d6067bce5ea2e721144
Author: mathp <mathp@chromium.org>
Date: Mon Feb 13 18:42:27 2017

[UI Strings] Remove unused strings in ui/strings/ui_strings.grd

BUG= 690075 
TEST=builds

Review-Url: https://codereview.chromium.org/2692893002
Cr-Commit-Position: refs/heads/master@{#450029}

[modify] https://crrev.com/46445b7459ec3f31ee268d6067bce5ea2e721144/ui/strings/ui_strings.grd

Comment 13 by ma...@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment