New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690073 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 620034



Sign in to add a comment

Use gradle java.filter.exclude to exclude files

Project Member Reported by wnwen@chromium.org, Feb 8 2017

Issue description

main.java.filter.exclude (
"path...*",
"*...path",
)

Seems to work for ./gradlew build even though the files can still be seen in the editor.

Have to get rid of symlink-java anyways.
 

Comment 1 by wnwen@chromium.org, Feb 8 2017

Symlink-java causes duplication file errors when we include the same symlink files in multiple project modules. Including the same physical directories is okay though, AS is smart enough to know that that both are the same, not so with the symlinks.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9032b352ce46f107da00bf7b00ece989d86dcfb5

commit 9032b352ce46f107da00bf7b00ece989d86dcfb5
Author: wnwen <wnwen@chromium.org>
Date: Thu Feb 09 15:53:33 2017

Android: Replace symlinks with gradle filters

Use filters to exclude unwanted files from source directories instead of
creating symlink dirs for android studio gradle scripts.

Paves the way for multiple modules including the same source dirs.

BUG= 690073 

Review-Url: https://codereview.chromium.org/2682183002
Cr-Commit-Position: refs/heads/master@{#449301}

[modify] https://crrev.com/9032b352ce46f107da00bf7b00ece989d86dcfb5/build/android/gradle/android.jinja
[modify] https://crrev.com/9032b352ce46f107da00bf7b00ece989d86dcfb5/build/android/gradle/generate_gradle.py
[modify] https://crrev.com/9032b352ce46f107da00bf7b00ece989d86dcfb5/docs/android_studio.md

Comment 3 by wnwen@chromium.org, Feb 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment