New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690071 link

Starred by 2 users
Status: Fixed
Owner:
vakh@chromium.org
Closed: Feb 2017
Cc:
melandory@chromium.org
nparker@chromium.org
█ awoz@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

SUBRESOURCE_FILTER should use value 13

Project Member Reported by vakh@chromium.org, Feb 8 2017 
The internal version of the proto uses SUBRESOURCE_FILTER = 13, so that's what Chromium proto should also use.

Defined here: https://cs.chromium.org/chromium/src/components/safe_browsing_db/safebrowsing.proto?type=cs&l=288
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0827cde83fe81c9731090ce01e7ce34e6d4b9b2

commit d0827cde83fe81c9731090ce01e7ce34e6d4b9b2
Author: vakh <vakh@chromium.org>
Date: Wed Feb 08 19:16:49 2017

Use the correct enum value for SUBRESOURCE_FILTER

The internal proto uses value 13 for SUBRESOURCE_FILTER so Chromium
should use the same value.

BUG= 690071 

Review-Url: https://codereview.chromium.org/2685023002
Cr-Commit-Position: refs/heads/master@{#449058}

[modify] https://crrev.com/d0827cde83fe81c9731090ce01e7ce34e6d4b9b2/components/safe_browsing_db/safebrowsing.proto

Comment 2 by vakh@chromium.org, Feb 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment