New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690069 link

Starred by 1 user
Status: Verified
Owner:
█ deadbeef@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
jansson@chromium.org
█ emadomara@chromium.org
webrtc-network-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression

Blocking:
issue webrtc:6972



Sign in to add a comment

WebRTC DTLS-SRTP to SDES-SRTP fallback stopped working in M57

Project Member Reported by deadbeef@chromium.org, Feb 8 2017 
Chrome still supports both DTLS-SRTP and SDES-SRTP. In order to ease the transition from SDES to DTLS, we've supported fallback for quite some time; if you apply a remote offer with both "a=fingerprint" and "a=crypto", "a=crypto" will be ignored.

However, recently this started producing an error. See the linked webrtc bug. This will make the transition from SDES to DTLS more difficult for any endpoints still using SDES.

This has been fixed, and verified as fixed; this bug is only to request a merge to M57.

Comment 1 by gov...@chromium.org, Feb 8 2017 

Please apply appropriate OS labels. Thank you.

Comment 2 by deadbeef@chromium.org, Feb 8 2017

Labels: OS-All
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 9 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Feb 9 2017 

Please merge your change to M57 branch 2987 before 5:00 PM PT, Friday 02/10 so we can take it in for next week beta release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2017

Labels: merge-merged-57
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/76ad439d6c00e2f3ee62e417390541616522a35e

commit 76ad439d6c00e2f3ee62e417390541616522a35e
Author: deadbeef <deadbeef@webrtc.org>
Date: Thu Feb 09 22:09:38 2017

Merge to M57: Only set certificate on DTLS transport if fingerprint is found in SDP.

This is used for fallback from DTLS to SDES encryption, which we probably still
want to support. Setting a certificate puts the DTLS transport in a "DTLS
enabled" mode, so it should be delayed until SDP with "a=fingerprint" is set.

BUG= chromium:690069 
NOTRY=True
NOPRESUBMIT=True

Review-Url: https://codereview.webrtc.org/2681403002
Cr-Commit-Position: refs/branch-heads/57@{#4}
Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123}

[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/api/peerconnectioninterface_unittest.cc
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/api/test/fakertccertificategenerator.h
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/base/sslfingerprint.cc
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/base/sslfingerprint.h
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/p2p/base/faketransportcontroller.h
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/p2p/base/jseptransport.cc
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/p2p/base/transportcontroller.cc
[modify] https://crrev.com/76ad439d6c00e2f3ee62e417390541616522a35e/webrtc/p2p/base/transportdescriptionfactory.cc

Comment 6 by gov...@chromium.org, Feb 9 2017

Labels: -Merge-Approved-57
Per comment #5, this is already merged to M57.
►

Sign in to add a comment