New issue
Advanced search Search tips

Issue 690068 link

Starred by 2 users
Status: Fixed
Owner:
gan...@chromium.org
Closed: Feb 2017
Cc:
grt@chromium.org
sorin@chromium.org
waff...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug-Regression



Sign in to add a comment

"--system-level" parameter is seen twice while installing Chrome.

Project Member Reported by pbomm...@chromium.org, Feb 8 2017 
Chrome Version: Across all Current serving Chrome versions
OS: Windows 7

What steps will reproduce the problem?
1. Try to install Chrome from  : 
https://www.google.com/chrome/browser/desktop/index.html
https://www.chromium.org/getting-involved/dev-channel

2. open process explorer or task manager and observe the parameters whild Chrome getting installed.


What is the expected result?
There should be just one --system-level parameter.

What happens instead?
There are two --system-level parameters, Please find the screenshots for reference.


Note : I am just tagging M57 for now, Since this is a server side Chrome milestone won't be that helpful anyways.
Stable.png
253 KB View Download

Comment 1 by sorin@chromium.org, Feb 8 2017

Owner: gan...@chromium.org
Omaha is adding one --system-level command line argument when the appid is Chrome. The code looks like this, Omaha open source example given, but Google Update code is identical.

The Omaha code has been like this since a very long time.

https://github.com/google/omaha/blob/master/omaha/goopdate/installer_wrapper.cc#L719

There is a problem with hardcoding the Chrome app id string literal here, in the light of future Chrome SXS work.

Comment 2 by grt@chromium.org, Feb 9 2017

Status: Fixed (was: Available)
--system-level was removed from the update configs yesterday, so this has been fixed.

Sorin and Ganesh: I believe you're in the clear to remove the special-case in Omaha if you wish -- Chrome's installer (setup.exe) and mini_installer both sniff the "GoogleUpdateIsMachine" environment variable now.

Comment 3 by gan...@chromium.org, Feb 9 2017 

Hi Greg, who sets the "GoogleUpdateIsMachine"? I do not see Omaha setting it, nor code in Chromium.

Comment 4 by grt@chromium.org, Feb 10 2017 

Responding directly.
►

Sign in to add a comment