The info icon in the account chooser should consume the click |
||||||
Issue descriptionThe PSL matches are displayed with an icon in the account chooser. The icon shows a tooltip on hover. The click in the icon should not propagate to the parent resulting in choosing a credential.
,
Feb 8 2017
This is a requirement from the security team for M57.
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ac642ad2d6c45b0a6d293e753997bcb03470cd commit f8ac642ad2d6c45b0a6d293e753997bcb03470cd Author: vasilii <vasilii@chromium.org> Date: Wed Feb 08 18:34:02 2017 Make the information icon in the account chooser consume the mouse click. This affects both Views platforms and Mac. BUG= 690061 Review-Url: https://codereview.chromium.org/2687533006 Cr-Commit-Position: refs/heads/master@{#449040} [modify] https://crrev.com/f8ac642ad2d6c45b0a6d293e753997bcb03470cd/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm [modify] https://crrev.com/f8ac642ad2d6c45b0a6d293e753997bcb03470cd/chrome/browser/ui/views/passwords/credentials_item_view.cc
,
Feb 9 2017
I want to merge r449040 back. It contains a security fix for the feature we launch in M57.
,
Feb 9 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2017
Please merge your change to M57 branch 2987 before 5:00 PM PT, Friday 02/10 so we can take it in for next week beta release. Thank you.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/322486c1cd367137f0063b89ecd2aaf91a175c97 commit 322486c1cd367137f0063b89ecd2aaf91a175c97 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Feb 09 19:17:41 2017 Make the information icon in the account chooser consume the mouse click. This affects both Views platforms and Mac. BUG= 690061 Review-Url: https://codereview.chromium.org/2687533006 Cr-Commit-Position: refs/heads/master@{#449040} (cherry picked from commit f8ac642ad2d6c45b0a6d293e753997bcb03470cd) Review-Url: https://codereview.chromium.org/2680163007 . Cr-Commit-Position: refs/branch-heads/2987@{#411} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/322486c1cd367137f0063b89ecd2aaf91a175c97/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm [modify] https://crrev.com/322486c1cd367137f0063b89ecd2aaf91a175c97/chrome/browser/ui/views/passwords/credentials_item_view.cc
,
Feb 9 2017
,
Apr 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vasi...@chromium.org
, Feb 8 2017