Valery, I think you said you still had something in experimental... did you want to kill that completely or move it to a new flag?

WM overview shadows still depend on material experimental, although I'm not sure why, because my reading of the comment indicates that the code just doesn't work. I'm not sure why we have what amounts to dead code hidden behind a deprecated flag. I think we should just comment the code out and then either fix the code (since now programmatic shadows exist --- although I doubt that actually makes this easy to fix since they're very similar in function to the old shadows) or remove it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23d6ceb29374e303c7bfd356c4455fde45ca208

commit a23d6ceb29374e303c7bfd356c4455fde45ca208
Author: estade <estade@chromium.org>
Date: Wed Feb 15 00:47:09 2017

Gut ash::MaterialDesignController, and remove the about:flags entry.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with  bug 685837  was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG= 690048 , 685837 

Review-Url: https://codereview.chromium.org/2692663002
Cr-Commit-Position: refs/heads/master@{#450531}

[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/BUILD.gn
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/ash_switches.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/ash_switches.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/material_design/material_design_controller.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/material_design/material_design_controller.h
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/common/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/shelf/shelf_constants.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/chromeos/power/power_status_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/chromeos/power/power_status_view_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/date/system_info_default_view_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/test/BUILD.gn
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/common/test/material_design_controller_test_api.cc
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/common/test/material_design_controller_test_api.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/dip_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/mus/window_manager_application.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/screen_util_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/BUILD.gn
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/test/ash_md_test_base.cc
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/test/ash_md_test_base.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_base.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_base.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_helper.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_helper.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_helper_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/app/generated_resources.grd
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/browser/about_flags.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/test/base/browser_with_test_window_test.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/test/base/view_event_test_platform_part_chromeos.cc

ChromeOs:9304.0.0/Chrome:58.0.3015.0