New issue
Advanced search Search tips

Issue 690041 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 765462



Sign in to add a comment

Fix failing ContextualSearchManagerTests on Nexus 5

Project Member Reported by shaktisahu@chromium.org, Feb 8 2017

Issue description

Few tests fail in ContextualSearchManagerTest, which are flaky and this only fails for nexus 5 running android 4.4 with certain gn args (same as CQ bots).

testTapContentVisibility
testSwipeExpand
testChainedTapsRemovedFromHistory
testTapCloseRemovedFromHistory

The issue appears when there is no internet connectivity. The contextual search manager tests depend on online connectivity for the google search even though the main page content is delivered from an embedded server. This happens on Nexus 5 with Kitkat installed.

Here are the gn args:
dcheck_always_on = true
ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
proprietary_codecs = true
symbol_level = 1
target_os = "android"
use_goma = true

This issue came up when working on https://codereview.chromium.org/2642303002/

https://codereview.chromium.org/2642303002/diff/220001/content/browser/android/web_contents_observer_proxy.cc#newcode163

Specifically, these tests need to handle when the HTTP failure status codes correctly.

 
Description: Show this description
Cc: donnd@chromium.org twelling...@chromium.org
Components: -UI>Browser>Search>ContextualSearch UI>Browser>Mobile>TouchToSearch
Labels: android-fe-triaged
Status: Available (was: Untriaged)

Comment 3 by donnd@google.com, Feb 13 2018

Blocking: 765462

Sign in to add a comment