Min height and flex-column with space between expands bigger than needed
Reported by
sombragr...@gmail.com,
Feb 8 2017
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: Load attached web test case in chrome 56 and observe the wrapper is taller than it needs be. In my case is 1480px tall and the min-height is actually less than that. It seems removing the min-height or not using the space between fixes the issue. What is the expected behavior? It shouldn't happen that since there's no need for the elements to go that tall. What went wrong? The height of the wrapper is much more than what it should be. Did this work before? Yes 55 Does this work in other browsers? Yes Chrome version: 56.0.2924.87 Channel: stable OS Version: OS X 10.12.3 Flash Version: Shockwave Flash 24.0 r0
,
Feb 8 2017
,
Feb 8 2017
Bisect: 426177 (good) - 426182 (bad), 56.0.2896.0 https://chromium.googlesource.com/chromium/src/+log/e023c78e..292397ed?pretty=fuller Suspecting r426178 "[css-flexbox] Remove now-unnecessary numberOfInFlowPositionedChildren" Repro note: a more convenient test case attached with the flexbox element painted in a different color.
,
Feb 9 2017
Could testing team please confirm the regression range?
,
Feb 9 2017
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.2 using chrome version 56.0.2924.87 and canary 58.0.3004.0. This is regression issue broken in M56. Please find the bisect information as below Narrow Bisect:: ================ Good ::56.0.2889.0 --- (official build 424926) Bad:: 56.0.2900.0 --- (official build 427219) Change Log:: ============== https://chromium.googlesource.com/chromium/src/+log/e023c78ef194d8b0d1d8a5cf12c2b59de0e5b85c..87ce46583a3f21ba62862774cff5438dc4b79443 Possible suspect:: https://chromium.googlesource.com/chromium/src/+/87ce46583a3f21ba62862774cff5438dc4b79443 cbiesinger@ Could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue. Thanks,
,
Feb 13 2017
Ah that is a little subtle... found the bug.
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f63ac52a3a74c9856d6fead1b1fb26a4948b35fe commit f63ac52a3a74c9856d6fead1b1fb26a4948b35fe Author: cbiesinger <cbiesinger@chromium.org> Date: Tue Feb 14 15:44:41 2017 [css-flexbox] Don't add extra space-between space at the end This is a regression from https://crrev.com/2429933002. When processing the last item on a row we should not add justify-content space to the row height. I incorrectly simplified the code in that patch. Weirdly we had no tests for this :( R=eae@chromium.org BUG= 690024 Review-Url: https://codereview.chromium.org/2697623003 Cr-Commit-Position: refs/heads/master@{#450364} [add] https://crrev.com/f63ac52a3a74c9856d6fead1b1fb26a4948b35fe/third_party/WebKit/LayoutTests/css3/flexbox/justify-content-space-between.html [modify] https://crrev.com/f63ac52a3a74c9856d6fead1b1fb26a4948b35fe/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
,
Feb 14 2017
,
Feb 15 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0e875601e88a69b9d6d6943cc6a2215bb0ce48f commit d0e875601e88a69b9d6d6943cc6a2215bb0ce48f Author: Christian Biesinger <cbiesinger@chromium.org> Date: Wed Feb 15 16:52:41 2017 [css-flexbox] Don't add extra space-between space at the end This is a regression from https://crrev.com/2429933002. When processing the last item on a row we should not add justify-content space to the row height. I incorrectly simplified the code in that patch. Weirdly we had no tests for this :( R=eae@chromium.org BUG= 690024 Review-Url: https://codereview.chromium.org/2697623003 Cr-Commit-Position: refs/heads/master@{#450364} (cherry picked from commit f63ac52a3a74c9856d6fead1b1fb26a4948b35fe) Review-Url: https://codereview.chromium.org/2692213006 . Cr-Commit-Position: refs/branch-heads/2987@{#522} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [add] https://crrev.com/d0e875601e88a69b9d6d6943cc6a2215bb0ce48f/third_party/WebKit/LayoutTests/css3/flexbox/justify-content-space-between.html [modify] https://crrev.com/d0e875601e88a69b9d6d6943cc6a2215bb0ce48f/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
,
Feb 22 2017
Rechecked this issue on chrome version 57.0.2987.74 on Windows 10, MAC 10.12.3, Ubuntu 14.04 using the test case provided in comment#4. Fix is working as intended. The height of the wrapper is displayed as expected. Adding TE-Verified labels. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 Deleted