New issue
Advanced search Search tips

Issue 690014 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593



Sign in to add a comment

Remove the VTTRegion-related bits of TextTrack

Project Member Reported by foolip@chromium.org, Feb 8 2017

Issue description

The region-related bits are regions, addRegion() and removeRegion().

These bits have been removed from the WebVTT spec:
https://github.com/w3c/webvtt/pull/31
 

Comment 1 by f...@opera.com, Feb 8 2017

The first one has some non-trivial footprint in tests, so might be a bit of work to pull out. The last two looks reasonably trivial though.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/037ca4bef92ddae569a757a66006d60cfcc7bdc5

commit 037ca4bef92ddae569a757a66006d60cfcc7bdc5
Author: fs <fs@opera.com>
Date: Fri Feb 10 11:30:28 2017

Implement VTTCue.region and sync the VTTRegion interface

This CL implements the VTTCue.region property, replacing 'regionId'. The
main implementation mechanism is a new map in VTTParser that tracks the
regions currently seen.

Rewrite the region parser test to be based on cues rather than the list
of regions. This will ease the removal of TextTrack.regions.

Sync the VTTRegion with the current spec by

 * renaming the 'height' property to 'lines',

 * adding and using the ScrollSetting IDL enumeration type and

 * dropping the 'id' and 'track' properties.

Update tests as needed to match the above changes.

BUG= 690014 

Review-Url: https://codereview.chromium.org/2682333002
Cr-Commit-Position: refs/heads/master@{#449589}

[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/LayoutTests/media/track/captions-webvtt/header-regions.vtt
[delete] https://crrev.com/75d9c7e22b281a5e22a6382b9f9a2d9a9dbeac4f/third_party/WebKit/LayoutTests/media/track/regions-webvtt/text-track-cue-region-attribute.html
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-display.html
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-parser.html
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/InbandTextTrack.cpp
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTCue.h
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.h
[modify] https://crrev.com/037ca4bef92ddae569a757a66006d60cfcc7bdc5/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.idl

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6ca2907e1f31f01920b4d3447030dd47bb8f211

commit f6ca2907e1f31f01920b4d3447030dd47bb8f211
Author: fs <fs@opera.com>
Date: Fri Feb 10 23:44:37 2017

Remove TextTrack.regions and VTTRegionList

Removed from the WebVTT spec https://github.com/w3c/webvtt/pull/31

Because we no longer need to track a list of regions in TextTrack, we
can also remove all the plumbing between the parser and the (loadable)
TextTrack.

BUG= 690014 

Review-Url: https://codereview.chromium.org/2685943004
Cr-Commit-Position: refs/heads/master@{#449791}

[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-display.html
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/LayoutTests/media/track/regions-webvtt/vtt-region-dom-layout.html
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/HTMLTrackElement.h
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/LoadableTextTrack.cpp
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/LoadableTextTrack.h
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/TextTrack.cpp
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/TextTrack.h
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/TextTrack.idl
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
[delete] https://crrev.com/621d3a7e8220105302d9ceb646463fcdd729625c/third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.cpp
[delete] https://crrev.com/621d3a7e8220105302d9ceb646463fcdd729625c/third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.h
[delete] https://crrev.com/621d3a7e8220105302d9ceb646463fcdd729625c/third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.idl
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
[modify] https://crrev.com/f6ca2907e1f31f01920b4d3447030dd47bb8f211/third_party/WebKit/Source/core/loader/TextTrackLoader.h

Comment 5 by f...@opera.com, Feb 11 2017

Owner: f...@opera.com
Status: Fixed (was: Available)

Sign in to add a comment