New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690011 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 636153



Sign in to add a comment

tear_down_process fails silently in typ

Project Member Reported by nedngu...@google.com, Feb 8 2017

Issue description

In my 4th attempt to test out the typ change to browser_test_runner, the gpu test were failing on the bot because the suite was leaking browser. (example log: https://chromium-swarm.appspot.com/task?id=342e79945fc3aa10&refresh=10&show_raw=1)

This was in facts caused by a bug in tear_down_process & fixed by https://codereview.chromium.org/2671383003/ (see the diff to the 1st patch). 

It was a bit hard to debug this because the failure in tear_down_process was completely silent: there is Exception output to stdout, it did not change return code of typ. If the swarming infra did not check for leaking processes, we wouldn't have been able to catch this bug.

I think it's a bit risky to move the new harness to typ while typ still handle this kind of failure silently.
 
Status: Available (was: Untriaged)
It looks like we typ captures the results from the teardown calls, but doesn't actually do anything with them. I don't know/remember why this would be the case, but I suspect it's just a bug that should be easy enough to fix.
Labels: typ
Labels: -typ Build-Tools-TYP

Comment 4 by kbr@chromium.org, Feb 28 2017

Blocking: -636153

Comment 5 by kbr@chromium.org, Feb 28 2017

Blockedon: 636153
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 27 2017

Labels: Hotlist-Google
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 27

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Build
Status: Available (was: Untriaged)
This is still an issue.

Sign in to add a comment