New issue
Advanced search Search tips

Issue 689999 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Password Generation] Empty fields are disappeared from generation uploads.

Project Member Reported by dvadym@chromium.org, Feb 8 2017

Issue description

After changes in CL https://codereview.chromium.org/2637823002/, fields with empty name/id were skipped in uploads, that breaks password generation on most sites with such fields.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17c2759535e8a90b3bda092dcd4207ce554ee263

commit 17c2759535e8a90b3bda092dcd4207ce554ee263
Author: dvadym <dvadym@chromium.org>
Date: Wed Feb 08 16:03:34 2017

[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with empty name/id disappeared from uploads. This CL fixes it.

BUG= 689999 

Review-Url: https://codereview.chromium.org/2687683002
Cr-Commit-Position: refs/heads/master@{#449003}

[modify] https://crrev.com/17c2759535e8a90b3bda092dcd4207ce554ee263/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/17c2759535e8a90b3bda092dcd4207ce554ee263/components/password_manager/core/browser/password_form_manager_unittest.cc

Comment 2 by dvadym@chromium.org, Feb 10 2017

Labels: Merge-Request-57
This is a small bug fix.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 10 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74a6c5fae2ae05bd712fabc362d81d9f81a67e95

commit 74a6c5fae2ae05bd712fabc362d81d9f81a67e95
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Fri Feb 10 13:54:25 2017

[Merge] [Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with empty name/id disappeared from uploads. This CL fixes it.

BUG= 689999 

Review-Url: https://codereview.chromium.org/2687683002
Cr-Commit-Position: refs/heads/master@{#449003}
(cherry picked from commit 17c2759535e8a90b3bda092dcd4207ce554ee263)

Review-Url: https://codereview.chromium.org/2684033011 .
Cr-Commit-Position: refs/branch-heads/2987@{#434}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/74a6c5fae2ae05bd712fabc362d81d9f81a67e95/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/74a6c5fae2ae05bd712fabc362d81d9f81a67e95/components/password_manager/core/browser/password_form_manager_unittest.cc

Comment 5 by dvadym@chromium.org, Feb 10 2017

Status: Fixed (was: Started)

Sign in to add a comment