Issue metadata
Sign in to add a comment
|
2.1%-2.2% regression in webrtc_perf_tests at 16480:16480 |
||||||||||||||||||||
Issue descriptionLooks like two regressions after each other. Blame range for first increase: https://chromium.googlesource.com/external/webrtc/+log/3443bb75a08811a16fd2dd406f72878703f4a861..c16fa5ea692e06992c30c8b9853356b90da74e2a Main culprit for second increase: https://chromium.googlesource.com/external/webrtc/+/69fb2cca4d54f3df7ceddcd1c3e9b0ad80fa849b This is actually a revert of one of the CLs in the first range, which makes little sense since both regressions are increases.
,
Feb 8 2017
,
Feb 8 2017
I don't think it is my CL because it was already reverted and the issue persists. I suspect https://chromium.googlesource.com/external/webrtc/+/2bc6864278d74e88711f62b4a735d6e7af4dc4dd because it has caused perf problems previously.
,
Feb 8 2017
I think it's very likely that this is my CL. It's logical that it would cause a delay increase.
,
Feb 10 2017
So, is it WAI?
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/ad9010c983631356bef481a2fc609b152a4e1410 commit ad9010c983631356bef481a2fc609b152a4e1410 Author: kthelgason <kthelgason@webrtc.org> Date: Tue Feb 14 08:46:51 2017 Make sure initial framedrop is off where quality scaling is off. BUG= chromium:689972 ,chromium:689915 Review-Url: https://codereview.webrtc.org/2684683004 Cr-Commit-Position: refs/heads/master@{#16602} [modify] https://crrev.com/ad9010c983631356bef481a2fc609b152a4e1410/webrtc/video/vie_encoder.cc [modify] https://crrev.com/ad9010c983631356bef481a2fc609b152a4e1410/webrtc/video/vie_encoder_unittest.cc
,
Feb 20 2017
,
Feb 20 2017
I take it it was fixed in commit #16602? If you agree, it would make sense to link the corresponding bumps on the graphs to this bug too.
,
Feb 20 2017
Thanks for the suggestion Nisse, will do. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hlundin@chromium.org
, Feb 8 2017