New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689972 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.1%-2.2% regression in webrtc_perf_tests at 16480:16480

Project Member Reported by hlundin@chromium.org, Feb 8 2017

Issue description

Looks like two regressions after each other.

Blame range for first increase: https://chromium.googlesource.com/external/webrtc/+log/3443bb75a08811a16fd2dd406f72878703f4a861..c16fa5ea692e06992c30c8b9853356b90da74e2a

Main culprit for second increase: https://chromium.googlesource.com/external/webrtc/+/69fb2cca4d54f3df7ceddcd1c3e9b0ad80fa849b

This is actually a revert of one of the CLs in the first range, which makes little sense since both regressions are increases.



 
Cc: kthelgason@chromium.org nisse@chromium.org holmer@chromium.org hbos@chromium.org

Comment 3 by sakal@chromium.org, Feb 8 2017

Cc: sakal@chromium.org
Owner: kthelgason@chromium.org
I don't think it is my CL because it was already reverted and the issue persists. I suspect https://chromium.googlesource.com/external/webrtc/+/2bc6864278d74e88711f62b4a735d6e7af4dc4dd because it has caused perf problems previously.
Cc: magjed@chromium.org
I think it's very likely that this is my CL. It's logical that it would cause a delay increase.
So, is it WAI?
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/ad9010c983631356bef481a2fc609b152a4e1410

commit ad9010c983631356bef481a2fc609b152a4e1410
Author: kthelgason <kthelgason@webrtc.org>
Date: Tue Feb 14 08:46:51 2017

Make sure initial framedrop is off where quality scaling is off.

BUG= chromium:689972 ,chromium:689915

Review-Url: https://codereview.webrtc.org/2684683004
Cr-Commit-Position: refs/heads/master@{#16602}

[modify] https://crrev.com/ad9010c983631356bef481a2fc609b152a4e1410/webrtc/video/vie_encoder.cc
[modify] https://crrev.com/ad9010c983631356bef481a2fc609b152a4e1410/webrtc/video/vie_encoder_unittest.cc

Status: Fixed (was: Assigned)

Comment 8 by nisse@chromium.org, Feb 20 2017

I take it it was fixed in commit #16602? If you agree, it would make sense to link the corresponding bumps on the graphs to this bug too.
Thanks for the suggestion Nisse, will do.

Sign in to add a comment