Use last_access_time to filter out outdated asset downloads. |
||||
Issue descriptionIn issue 687888 we used only created_time for asset downloads and both created and last_access times for offline pages, because this data is not collected for asset downloads. We should use last_access_times once it is provided.
,
Mar 6 2017
There is some progress in issue 689981 , so I am starting working on this issue.
,
Mar 6 2017
They do not update last_access_time when a download is opened through NTP. I will add this to issue 689981 and wait.
,
Mar 31 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdc707f2ed4d9fa302d5c81259ac67618d6c2b56 commit cdc707f2ed4d9fa302d5c81259ac67618d6c2b56 Author: vitaliii <vitaliii@chromium.org> Date: Tue Apr 04 09:58:11 2017 [NTP::Downloads] Use last access time to filter old asset downloads. Previously, last_access_time was not provided in DownloadItem. Now it is, so in this CL we use it to filter out outdaded asset downloads (same way as it was done for offline pages - either creation time or last access time (if ever opened) is considered). BUG= 689965 Review-Url: https://codereview.chromium.org/2787303002 Cr-Commit-Position: refs/heads/master@{#461671} [modify] https://crrev.com/cdc707f2ed4d9fa302d5c81259ac67618d6c2b56/chrome/browser/ntp_snippets/download_suggestions_provider.cc [modify] https://crrev.com/cdc707f2ed4d9fa302d5c81259ac67618d6c2b56/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc [modify] https://crrev.com/cdc707f2ed4d9fa302d5c81259ac67618d6c2b56/content/public/test/fake_download_item.cc [modify] https://crrev.com/cdc707f2ed4d9fa302d5c81259ac67618d6c2b56/content/public/test/fake_download_item.h
,
Apr 4 2017
They *do* update last_access_time when a download is opened through NTP. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vitaliii@chromium.org
, Feb 8 2017