New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689937 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 645917



Sign in to add a comment

[Field trial params] Extend the Java API to better support reading field trial params via features

Project Member Reported by jkrcal@chromium.org, Feb 8 2017

Issue description

Allow reading a field trial param from Java via its name and via a name of a feature it is associated to.
 
Blocking: 645917
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abfc1c53a0963f4ac88a634895a5ac9afbb677eb

commit abfc1c53a0963f4ac88a634895a5ac9afbb677eb
Author: jkrcal <jkrcal@chromium.org>
Date: Mon Feb 13 14:39:00 2017

[Field trial params] Getting field trial params by feature name in Java.

This CL adds support to read field trial params in Java using the name
of the feature they are associated to. It also brings parsing values to
primitive types on par to what is available in c++ code.

In follow-up CLs I plan to
 - extend ChromeFeatureList to support overriding param values from junit tests;
 - use the new functions from ntp_snippets java code.

BUG= 689937 

Review-Url: https://codereview.chromium.org/2686763003
Cr-Commit-Position: refs/heads/master@{#449952}

[modify] https://crrev.com/abfc1c53a0963f4ac88a634895a5ac9afbb677eb/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/abfc1c53a0963f4ac88a634895a5ac9afbb677eb/chrome/browser/android/chrome_feature_list.cc

The next step for this bug is to extend ChromeFeatureList to support overriding param values from junit tests.

Comment 4 by jkrcal@chromium.org, Jul 24 2017

Status: Fixed (was: Started)
Better support for junit tests is not needed, at the moment. Marking the bug as fixed.

Sign in to add a comment