Infobar arrow anchor position incorrect in Harmony/Mac
Reported by
dmascare...@etouch.net,
Feb 8 2017
|
|||||||
Issue descriptionChrome Version:57.0.2987.37 (Official Build) (64-bit)47a57c88d21c9db6c802e723966c0d7a1e5a991c-refs/branch-heads/2987@{#374} 64 bit OS: Mac (10.11.6,10.12.1) Pre-condition: 1. Enable 'secondary-ui-md' flag. 2. Make Firefox as Default browser. What steps will reproduce the problem? 1. Freshly launch chrome and observe ‘Default browser’ infobar. Actual: Tip of the ‘Default browser’ infobar is not seen properly. Expected: Tip of the ‘Default browser’ infobar should be proper. This is regression issue, broken in ‘M 57’ and below is manual bisect: Good build:57.0.2937.0 Bad build:57.0.2938.0 Note: Issue is not seen on Windows and Linux OS.
,
Feb 8 2017
,
Feb 10 2017
tapted: Did you ask for secondary-ui-md to be tested on Mac? Normally I'd close this sort of thing and request that off-by-default flags not be tested unless requested, but maybe you requested it.
,
Feb 12 2017
> tapted: Did you ask for secondary-ui-md to be tested on Mac? didn't ask for it, but I think bugs like this are good. This is something we may have easily missed, and will need a fix before --secondary-ui-md is on by default on Mac.
,
Feb 16 2017
,
Feb 16 2017
,
Apr 12 2017
,
Apr 12 2017
Oops, accidental priority change.
,
May 5 2017
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3248f4867e7ac406e88ac458ae1d34c168506636 commit 3248f4867e7ac406e88ac458ae1d34c168506636 Author: tapted <tapted@chromium.org> Date: Tue May 09 04:25:05 2017 Mac: Fix infobar anchor under Harmony. For the most part, this is just a rename of `pageInfoBubblePointY` to `infoBarAnchorPointY` since it's only used for InfoBars, and never used for the page info bubble. page_info_bubble_controller.mm and other things anchoring off the location icon just use LocationBarViewMac::GetPageInfoBubblePoint() directly. Adds LocationBarViewMac::GetInfoBarAnchorPoint() since InfoBars will still have arrows under Harmony, while bubbles will not. BUG= 689906 Review-Url: https://codereview.chromium.org/2862003004 Cr-Commit-Position: refs/heads/master@{#470202} [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/browser_window_controller_private.h [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/browser_window_layout.h [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h [modify] https://crrev.com/3248f4867e7ac406e88ac458ae1d34c168506636/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
,
May 9 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dmascare...@etouch.net
, Feb 8 2017Owner: tapted@chromium.org
Status: Assigned (was: Unconfirmed)