New issue
Advanced search Search tips

Issue 689891 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Implement URL's toJSON()

Project Member Reported by annevank...@gmail.com, Feb 8 2017

Issue description

Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Cc: yhirano@chromium.org
 Issue 723954  has been merged into this issue.
Labels: -Pri-3 Hotlist-Interop Pri-2
Blink is now the only engine to not support toJSON for URL:
http://web-confluence.appspot.com/#!/catalog?releases=%5B%22Safari_11.1_OSX_10.13.4%22,%22Edge_17.17134_Windows_10.0%22,%22Firefox_61.0_Windows_10.0%22,%22Chrome_68.0.3440.75_Windows_10.0%22%5D&q=%22count:3%20and%20notin:chrome%22

There are tests which fail only in Chrome:
https://wpt.fyi/results/url/url-tojson.any.html?complete=true

I've bumped the priority and added Hotlist-Interop to this issue as this is one of quite few such APIs where Chrome alone is missing it.

yhirano@, do you believe this would be a simple fix?
Owner: jbroman@chromium.org
Status: Started (was: Available)
This is totally trivial AFAICT. So much so that I'm going to just steal this bug and send a CL.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95c28adc1d9b521918df000afb77e2190ca6dbd5

commit 95c28adc1d9b521918df000afb77e2190ca6dbd5
Author: Jeremy Roman <jbroman@chromium.org>
Date: Sun Sep 09 04:49:37 2018

Implement URL.prototype.toJSON.

Chromium is presently the only major vendor not to support it.

Bug:  689891 
Change-Id: Ibc7b0f1bf0da06f77d16cd9aeace44c2674807cc
Reviewed-on: https://chromium-review.googlesource.com/1215242
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589796}
[delete] https://crrev.com/981b3e050c56ad499d9a7ef29d7df187c1861120/third_party/WebKit/LayoutTests/external/wpt/url/idlharness.any-expected.txt
[delete] https://crrev.com/981b3e050c56ad499d9a7ef29d7df187c1861120/third_party/WebKit/LayoutTests/external/wpt/url/idlharness.any.worker-expected.txt
[delete] https://crrev.com/981b3e050c56ad499d9a7ef29d7df187c1861120/third_party/WebKit/LayoutTests/external/wpt/url/url-tojson.any-expected.txt
[delete] https://crrev.com/981b3e050c56ad499d9a7ef29d7df187c1861120/third_party/WebKit/LayoutTests/external/wpt/url/url-tojson.any.worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/blink/renderer/core/url/dom_url.h
[modify] https://crrev.com/95c28adc1d9b521918df000afb77e2190ca6dbd5/third_party/blink/renderer/core/url/url.idl

Labels: M-71
Status: Fixed (was: Started)

Sign in to add a comment