New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689889 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In guest mode, unnecessary blue focus is seen on last profile instead of first profile.

Reported by dmascare...@etouch.net, Feb 8 2017

Issue description

Chrome Version:58.0.3006.0 Revision d6822b0656d0a9a13ca7926806e22b3afa4d2bf9-refs/heads/master@{#448862}
OS: Mac (10.11.6,10.12.1)

Pre-condition: Add 2-3 profile/user.

What steps will reproduce the problem?
1. Launch chrome and Switch to Guest mode
2. Press ctrl-shift-m from keyboard (profile switcher menu gets open),observe the focus.

Actual: In guest mode, unnecessary blue focus is seen on last profile instead of first profile.
Expected:  Blue focus should be seen on first profile.

This is regression issue, broken in ‘M 58’ and below is Manual bisect:
Good build:58.0.3005.2
Bad build:58.0.3006.0

Note:1. Issue is not seen on Windows and Linux OS.
     2. Issue is seen on Main user after third person is added.
 
Actual.mov
1.2 MB Download
EXp.mov
1.2 MB Download
Owner: jlebel@chromium.org
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3005.2 (Revision: 448507).
Bad build: 58.0.3006.0 (Revision: 448862).

You are probably looking for a change made after 448585 (known good), but no later than 448586 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/97d545248e030879ef49e0aebb7f9643705360b1..eb2e0d02e494c55d5e3721fe8a70f2e4f289621f

From the CL above, assigning the issue to the concern owner

@jlebel:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2638853003

Note : 1.Mac specific issue Not in win and linux
2.Able to reproduce in latest Build #58.0.3006.0
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/888b44e14b7afac674d55e305c8dd89a393cbdac

commit 888b44e14b7afac674d55e305c8dd89a393cbdac
Author: jlebel <jlebel@chromium.org>
Date: Wed Feb 08 19:53:24 2017

macOS: Focus first profile

In crrev.com/2638853003, the last profile in the menu is getting focused.
This should have been the first profile.

BUG= 689889 

Review-Url: https://codereview.chromium.org/2682153002
Cr-Commit-Position: refs/heads/master@{#449069}

[modify] https://crrev.com/888b44e14b7afac674d55e305c8dd89a393cbdac/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Status: Fixed (was: Assigned)
Labels: TE-Verified-M58 TE-Verified-58.0.3012.0
Tested the issue on Mac 10.12.0 using chrome dev version 58.0.3012.0 with the steps mentioned in comment #0.Observed blue focus is seen on first profile which is working as intended.
Please find the attached screen cast for the same.Adding TE-Verified labels.
689889.mp4
829 KB View Download

Sign in to add a comment