Issue metadata
Sign in to add a comment
|
Don't show the DSE bubble over chrome://welcome-win10
Reported by
jshan...@etouch.net,
Feb 8 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 58.0.3006.0 d6822b0656d0a9a13ca7926806e22b3afa4d2bf9-refs/heads/master@{#448862} OS: Windows 10 Steps: 1. Freshly launch Chrome and observe Actual: First run bubble is misplaced. Expected: First run bubble should seen properly. This is a regression issue broken in M-58, will soon update the bisect info. Good build: 58.0.2999.0 Bad build: 58.0.3000.0
,
Feb 8 2017
Thanks for catching this! Updating the title and changing a few other things.
,
Feb 8 2017
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2541ce363e08db756a8418fee5fb195339b957e commit b2541ce363e08db756a8418fee5fb195339b957e Author: tmartino <tmartino@chromium.org> Date: Wed Feb 08 22:50:46 2017 Suppressing First Run bubble when viewing chrome://welcome-win10 BUG= 689888 Review-Url: https://codereview.chromium.org/2684963003 Cr-Commit-Position: refs/heads/master@{#449119} [modify] https://crrev.com/b2541ce363e08db756a8418fee5fb195339b957e/chrome/browser/first_run/first_run.cc
,
Feb 8 2017
,
Feb 8 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 8 2017
Will request merge once verified on Canary.
,
Feb 9 2017
Above issue is fixed on latest Canary version: 58.0.3006.0, please refer the attached screencast
,
Feb 9 2017
Correction: Canary version: 58.0.3007.0
,
Feb 9 2017
Requesting a merge then, per verification
,
Feb 9 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/807217a8bab04f878b2d3932fb1241168531871e commit 807217a8bab04f878b2d3932fb1241168531871e Author: Tommy Martino <tmartino@chromium.org> Date: Thu Feb 09 23:01:47 2017 Suppressing First Run bubble when viewing chrome://welcome-win10 BUG= 689888 Review-Url: https://codereview.chromium.org/2684963003 Cr-Commit-Position: refs/heads/master@{#449119} (cherry picked from commit b2541ce363e08db756a8418fee5fb195339b957e) Review-Url: https://codereview.chromium.org/2683113005 . Cr-Commit-Position: refs/branch-heads/2987@{#421} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/807217a8bab04f878b2d3932fb1241168531871e/chrome/browser/first_run/first_run.cc
,
Feb 15 2017
Tested the issue on Windows-10 using 57.0.2987.54 as per the comment#0. Observed that the fix is working as expected. Attaching screen cast for reference . Hence,adding the verified labels. Thanks. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sureshkumari@chromium.org
, Feb 8 2017Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: tmartino@chromium.org
Status: Assigned (was: Unconfirmed)