New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689888 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 658434



Sign in to add a comment

Don't show the DSE bubble over chrome://welcome-win10

Reported by jshan...@etouch.net, Feb 8 2017

Issue description

Chrome Version: 58.0.3006.0 d6822b0656d0a9a13ca7926806e22b3afa4d2bf9-refs/heads/master@{#448862} 
OS: Windows 10

Steps:
1. Freshly launch Chrome and observe

Actual: First run bubble is misplaced.

Expected: First run bubble should seen properly.

This is a regression issue broken in M-58, will soon update the bisect info.

Good build: 58.0.2999.0 
Bad build: 58.0.3000.0 


 
Actual_Expected_result.jpg
134 KB View Download
Cc: sureshkumari@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: tmartino@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build:58.0.2999.0  (revision : 447413)
Bad Build: 58.0.3000.0  (revision : 447669)

You are probably looking for a change made after 447607 (known good), but no later than 447608 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
 https://chromium.googlesource.com/chromium/src/+log/e027f6a77853952285de14c8b9009c208b4c2c99..f9a9ef14dfdb45e70a898024b5c690ac4bf3a5e0

From the CL above, assigning the issue to the concern owner 

tmartino@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2627363002

Note : Adding RB-Stable as this is a recent regression, please feel to edit/remove this.

Thanks!

Comment 2 by ew...@chromium.org, Feb 8 2017

Blocking: 658434
Cc: ew...@chromium.org
Labels: -M-58 M-57
Summary: Don't show the DSE bubble over chrome://welcome-win10 (was: Regression: First run bubble is misplaced for Windows 10.)
Thanks for catching this! Updating the title and changing a few other things.
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2541ce363e08db756a8418fee5fb195339b957e

commit b2541ce363e08db756a8418fee5fb195339b957e
Author: tmartino <tmartino@chromium.org>
Date: Wed Feb 08 22:50:46 2017

Suppressing First Run bubble when viewing chrome://welcome-win10

BUG= 689888 

Review-Url: https://codereview.chromium.org/2684963003
Cr-Commit-Position: refs/heads/master@{#449119}

[modify] https://crrev.com/b2541ce363e08db756a8418fee5fb195339b957e/chrome/browser/first_run/first_run.cc

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Will request merge once verified on Canary.
Above issue is fixed on latest Canary version: 58.0.3006.0, please refer the attached screencast
Screencast.mp4
310 KB View Download
Correction: Canary version: 58.0.3007.0
Labels: -Merge-TBD Merge-Request-57
Requesting a merge then, per verification
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 9 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 9 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807217a8bab04f878b2d3932fb1241168531871e

commit 807217a8bab04f878b2d3932fb1241168531871e
Author: Tommy Martino <tmartino@chromium.org>
Date: Thu Feb 09 23:01:47 2017

Suppressing First Run bubble when viewing chrome://welcome-win10

BUG= 689888 

Review-Url: https://codereview.chromium.org/2684963003
Cr-Commit-Position: refs/heads/master@{#449119}
(cherry picked from commit b2541ce363e08db756a8418fee5fb195339b957e)

Review-Url: https://codereview.chromium.org/2683113005 .
Cr-Commit-Position: refs/branch-heads/2987@{#421}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/807217a8bab04f878b2d3932fb1241168531871e/chrome/browser/first_run/first_run.cc

Labels: TE-Verified-57.0.2987.54 TE-Verified-M57
Tested the issue on Windows-10 using 57.0.2987.54 as per the comment#0.

Observed that the fix is working as expected.

Attaching screen cast for reference .

Hence,adding the verified labels.

Thanks.
689888.mp4
404 KB View Download

Sign in to add a comment