New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 689863 link

Starred by 1 user
Status: Fixed
Owner:
osh...@chromium.org
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In bookmark bar, tooltip does not get updated when changes are made to bookmarked page.

Reported by lpa...@etouch.net, Feb 8 2017 
Chrome Version: 57.0.2987.37 (Official Build) 47a57c88d21c9db6c802e723966c0d7a1e5a991c-refs/branch-heads/2987@{#374} (32/64-bit)
OS: Windows (7,8,10), Linux (14.04 LTS)

What steps will reproduce the problem?
1) Launch chrome, go to NTP and bookmark the page.
2) In bookmark bar, right click on added bookmark and select 'Edit'.
3) Clear the 'Name' field, change URL to 'chrome://' and 'Save' the changes.
4) Now mouse hover on bookmark and observe the tooltip.

Bookmarked page tooltip does not get updated after making the changes.

Bookmarked page tooltip should get updated after making the changes.

This is a Regression issue broken in M-56, will soon update other info
Manual bisect:
Good build: 56.0.2922.0 
Bad build: 56.0.2924.0 

Note: Issue is not seen on Mac OS.
bookmark_actual.mp4
861 KB View Download
bookmark_expected.mp4
692 KB View Download

Comment 1 by kkaluri@chromium.org, Feb 8 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: osh...@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build :  56.0.2922.0,  Revision Range- 432511
Bad build  :  56.0.2924.0,  Revision Range- 433059

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/5718f249711946f58932bc114a2e24b8aa33727f..e1b6ed732fb14986aa4d1db97de7208356b861f7

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/e1b6ed732fb14986aa4d1db97de7208356b861f7

Review-Url: https://codereview.chromium.org/2507743002

oshima@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Note:
-----
Observed this behavior on Ubuntu 14.04 on latest canary #58.0.3004.3


Thank You...
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dc0899d326b4d59ef71b6a49a7a786ab28a3125

commit 3dc0899d326b4d59ef71b6a49a7a786ab28a3125
Author: oshima <oshima@chromium.org>
Date: Mon Feb 20 10:33:47 2017

Clear the text cache when the tooltip text is updated.

BUG= 689863 
TEST=BookmarkBarViewTest.UpdateTooltipText

Review-Url: https://codereview.chromium.org/2687893002
Cr-Commit-Position: refs/heads/master@{#451591}

[modify] https://crrev.com/3dc0899d326b4d59ef71b6a49a7a786ab28a3125/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/3dc0899d326b4d59ef71b6a49a7a786ab28a3125/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

Comment 3 by osh...@chromium.org, Feb 21 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 21 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gov...@chromium.org, Feb 21 2017 

If possible, please merge your change to M57 branch 2987 by 5:00 PM PT today, Tuesday (02/21) so we can pick it up for this week beta release. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 21 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60f9e4e46a84f361dc10b99fee539805f0c2f69a

commit 60f9e4e46a84f361dc10b99fee539805f0c2f69a
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Feb 21 22:47:39 2017

Clear the text cache when the tooltip text is updated.

BUG= 689863 
TEST=BookmarkBarViewTest.UpdateTooltipText

Review-Url: https://codereview.chromium.org/2687893002
Cr-Commit-Position: refs/heads/master@{#451591}
(cherry picked from commit 3dc0899d326b4d59ef71b6a49a7a786ab28a3125)

Review-Url: https://codereview.chromium.org/2711473004 .
Cr-Commit-Position: refs/branch-heads/2987@{#626}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/60f9e4e46a84f361dc10b99fee539805f0c2f69a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/60f9e4e46a84f361dc10b99fee539805f0c2f69a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc

Comment 7 by osh...@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

Comment 8 by durga.behera@chromium.org, Feb 22 2017

Labels: TE-Verified-57.0.2987.74 TE-Verified-M57
Verified the issue on Ubuntu 14.04 and Win 10 using 57.0.2987.74 and its working fine.Please find the screencast for the same.
689863_Feb_22.ogv
1.5 MB View Download
►

Sign in to add a comment