New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 689783 link

Starred by 1 user
Status: Verified
Owner:
hidehiko@chromium.org
Closed: Feb 2017
Cc:
█ lhchavez@chromium.org
yusukes@chromium.org
hidehiko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Enable git cl lint PRESUBMIT check for components/arc and chrome/browser/chormeos/arc

Project Member Reported by hidehiko@chromium.org, Feb 8 2017 
Chrome Version: ToT
OS: ChromeOS

This is for tracking issue.
We'd like to enable "git cl lint" check on PRESUBMIT for components/arc and chrome/browser/chromeos/arc to reduce review time.

Current lint errors should be cleaned by crrev.com/2683633002.

Comment 1 by hidehiko@chromium.org, Feb 8 2017

Owner: hidehiko@chromium.org
Status: Started (was: Available)
CL is ready. https://codereview.chromium.org/2684723004/

This is not urgent, but earlier is better, I think.
I'm about sending a PSA for heads up, and let's enable it after a few days.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef74850fa87ad5b31dc7d7953429dce12193ec49

commit ef74850fa87ad5b31dc7d7953429dce12193ec49
Author: hidehiko <hidehiko@chromium.org>
Date: Thu Feb 09 09:28:10 2017

Enable presubmit lint check for ARC.

This CL enables presubmit check on uploading if the change is
lint error free.

BUG= 689783 
TEST=git cl presubmit --upload

Review-Url: https://codereview.chromium.org/2684723004
Cr-Commit-Position: refs/heads/master@{#449245}

[add] https://crrev.com/ef74850fa87ad5b31dc7d7953429dce12193ec49/chrome/browser/chromeos/arc/PRESUBMIT.py
[add] https://crrev.com/ef74850fa87ad5b31dc7d7953429dce12193ec49/components/arc/PRESUBMIT.py

Comment 3 by hidehiko@chromium.org, Feb 9 2017

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by sdantul...@chromium.org, May 8 2017

Labels: code-change
Status: Verified (was: Fixed)
►

Sign in to add a comment