New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689763 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 680406



Sign in to add a comment

MD Settings: consider ignoring tap on a label to change toggle/checkbox

Project Member Reported by scottchen@chromium.org, Feb 8 2017

Issue description

OS: All

According to bettes@, rows that contain toggle buttons should be clickable (the whole row). After this CL: https://codereview.chromium.org/2617533003/, some rows containing a toggle becomes non-interactive, and only clicking on the toggle button itself works.

What is the expected result?
Clicking on the row will change the toggle value.

What happens instead?
Some rows takes clicks, some rows don't.

Steps to fix should be: 
- Go through all the changed html in https://codereview.chromium.org/2617533003/
- Check every instance in the new code where <paper-toggle-button> is used (instead of <settings-toggle-button>
- Move the on-tap and "actionable" attributes onto the row container (instead of on the <paper-toggle-button>


 
toggle bug.mov
3.7 MB Download

Comment 1 by dbeam@chromium.org, Feb 8 2017

Blockedon: 680406

Comment 2 by bettes@chromium.org, Feb 10 2017

Okay, our stance on this UI might need some modification now that we've made checkboxes to switches and restricted card width.

Prior to the above changes, we had controls on the left and right hand side of the row with potentially 920px between each control. We allowed a click in the row to "activate" what was considered A LOT of dead space. I think that was the right call then but we now live in a pretty different UI. 

All controls (excluding dialogs and on startup) have controls on the right hand side and the card width is restricted to 640px. The notion to make the entire row clickable seems less important and arguably less intuitive now. (If we were to heatmap a row with a switch, I hypothesize that it's most likely that users will direct their clicks/taps to the actual switch and not the whitespace around it)

I think this will simplify our settings.box model as well: 

1. Unactionable row - text, text with hyperlinks 
2. Unactionable row with component - switches, dropdowns

3. Actionable row - subpage-arrow, outlinks, radio btns, and drop-down arrow (soon to be deprecated)
4. Actionable with component - two actionable parts divided by a rule line



@bettes why should rows with switches not be actionable? For example, tapping anywhere on a switch row in Android Settings will toggle the switch.

Comment 4 by dbeam@chromium.org, Feb 13 2017

Cc: -bettes@chromium.org scottchen@chromium.org
Owner: bettes@chromium.org
Summary: MD Settings: consider ignoring tap on a label to change toggle/checkbox (was: MD Settings: Some toggle rows aren't actionable (and some are))

Comment 5 by dbeam@chromium.org, Feb 13 2017

Labels: Hotlist-MD-Settings-General
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3245561158dde6808bd24b3322304369af52abac

commit 3245561158dde6808bd24b3322304369af52abac
Author: dbeam <dbeam@chromium.org>
Date: Tue Feb 14 08:49:01 2017

MD Settings: change how tap is handled on custom toggle rows

R=scottchen@chromium.org
BUG= 680406 ,689763
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2684853003
Cr-Commit-Position: refs/heads/master@{#450293}

[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/3245561158dde6808bd24b3322304369af52abac/chrome/test/data/webui/settings/metrics_reporting_tests.js

Status: Fixed (was: Assigned)
Re comment #2, we agreed in the Settings UX sync that rows with switches should be actionable -- clicking the text should toggle the switch. All other decisions from that comment are unchanged.

Marking this as fixed, but we should refer to this for related decisions in future.

Comment 8 by dbeam@chromium.org, Feb 27 2017

Labels: -Pri-1 Pri-3
Status: Available (was: Fixed)
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 7 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ----
Clearing my ownership of P3 UI>Settings bugs. Feel free to re-assign once triaging is complete. 

Sign in to add a comment