New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 689735 link

Starred by 1 user
Status: Fixed
Owner:
█ tansell@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
█ mcgreevy@chromium.org
dpranke@chromium.org
iannu...@google.com
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 686974



Sign in to add a comment

Add flag to allow exparchive to be used for isolation of all targets

Project Member Reported by tansell@chromium.org, Feb 7 2017 
Currently exparchive is only used for targets which end in _exparchive. 

The perf builders would like to test using exparchive for *all* targets (as it significantly reduces overhead on their bots see - https://bugs.chromium.org/p/chromium/issues/detail?id=686974).

This will also allow us to validate that exparchive is suitable to replace batcharchive in all places.

Comment 1 by tansell@chromium.org, Feb 15 2017

Status: Fixed (was: Started)
This has been deployed and tested on the perf waterfall but we forgot to add the bugs to the CLs.

The CLs which did this work are at;

 * https://chromium-review.googlesource.com/c/443024/
 * https://chromium-review.googlesource.com/c/442724/
 * https://chromium-review.googlesource.com/c/442904/
 * https://chromium-review.googlesource.com/c/436324/
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6477127e502255f62cfa126990e23122335760b9

commit 6477127e502255f62cfa126990e23122335760b9
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Fri Jun 09 05:20:20 2017

isolate: Add support for percentage experiments for exparchive.

In  https://crbug.com/689735  the perfbots where converted whole sale to
use exparchive instead of batcharchive. This significantly improve
performance.

However, we are worried that exparchive might not be faster in *all*
cases, so we want to run an experiment with a percentage of runs on a
builder using exparchive rather than batcharchive.

BUG= 689735 , 692940 , 598990 

Change-Id: Id00f35567edcdc83c77a38c8d0f86e3da1096519
Reviewed-on: https://chromium-review.googlesource.com/526874
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Michael McGreevy <mcgreevy@chromium.org>

[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build8.json
[modify] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.py
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build7.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build3.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build1.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build10.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build6.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build4.json
[modify] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/chromium_tests/api.py
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build9.json
[modify] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/api.py
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build2.json
[add] https://crrev.com/6477127e502255f62cfa126990e23122335760b9/scripts/slave/recipe_modules/isolate/examples/full.expected/use-exparchive-20percent-build5.json
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/69a3565e74d2187c337aada58f63427dbf48603b

commit 69a3565e74d2187c337aada58f63427dbf48603b
Author: Tim 'mithro' Ansell <tansell@chromium.org>
Date: Thu Jun 15 05:52:30 2017

linux_chromium_rel_ng: Enable exparchive for 5% of builds.

In  https://crbug.com/689735  the perfbots where converted whole sale to
use exparchive instead of batcharchive. This significantly improve
performance.

However, we are worried that exparchive might not be faster in *all*
cases, so we want to run an experiment with a percentage of runs on a
builder using exparchive rather than batcharchive.

BUG= 689735 , 692940 , 598990 

Change-Id: I2cbead4bbcb0c4f68b1ba111284b1521ff5d72fd
Reviewed-on: https://chromium-review.googlesource.com/532767
Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/69a3565e74d2187c337aada58f63427dbf48603b/scripts/slave/recipe_modules/chromium_tests/chromium_linux.py
[modify] https://crrev.com/69a3565e74d2187c337aada58f63427dbf48603b/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/69a3565e74d2187c337aada58f63427dbf48603b/scripts/slave/recipe_modules/chromium_tests/tests/api/trybot_steps.py
►

Sign in to add a comment