New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 689730 link

Starred by 1 user
Status: Fixed
Owner:
█ tansell@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
█ mcgreevy@chromium.org
dpranke@chromium.org
iannu...@google.com
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 524758



Sign in to add a comment

Fix swarm_hashes when using exparchive

Project Member Reported by tansell@chromium.org, Feb 7 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Tried to use multiple exparchive targets or exparchive and batcharchive together.
(2) 
(3)

What is the expected result?

swarm_hashes contains all the hashes and isolation+swarming works.

What happens instead?

swarm_hashes doesn't contain the full output.

Comment 1 by tansell@chromium.org, Feb 7 2017

Blocking: 524758
Originally landed by Dirk at https://chromium-review.googlesource.com/c/422460/

Fix is in https://chromium-review.googlesource.com/c/436324/

----
Previously this code failed in two ways;

 * When using multiple exparchive targets, swarm_hashes only contained
   the hash from the last exparchive command.

 * When exparchive and batcharchive isolation were used together the
   swarm_hashes only contained the hashes from the batcharchive command.

swarm_hashes needs to contain the swarm_hashes results from all the
isolation steps and now does. Also adding tests which prove these cases
no longer fail.
----

Comment 2 by tansell@chromium.org, Feb 7 2017

Components: Infra>Platform>Recipes

Comment 3 by tansell@chromium.org, Feb 16 2017

Status: Fixed (was: Started)
This was fixed in https://chromium-review.googlesource.com/c/436324/
►

Sign in to add a comment