isolate server should set content-disposition and filename for download... |
||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Go to https://isolateserver.appspot.com/content?namespace=default-gzip&digest=2ae23beb47393eccf58a63db5eac8edbeef05a7d (2) Click link of file. What is the expected result? File should be downloaded with the expected name (from the isolate file). What happens instead? Get a file downloaded with <random hash> (like 2ae23beb47393eccf58a63db5eac8edbeef05a7d)
,
Feb 7 2017
This can be done by setting the HTTP response header "Content-Disposition". http://stackoverflow.com/questions/13307499/http-download-file-name
,
Feb 7 2017
Ahhh you mean when browsing an isolated file with the web UI, create links that specify the isolated supplied basename. I'm fine with that.
,
Feb 8 2017
Yeah, if you browse to the file via hash, then it has no idea of the file name. Put if you click on a link from a isolated file, then it could easily send the filename through. Actually an alternative solution to "Content-Disposition" which might even be more reliable would be to allow urls of the type; https://isolateserver.appspot.com/content/<filename>?namespace=default-gzip&digest=2ae23beb47393eccf58a63db5eac8edbeef05a7d The '/<filename>' part of the URL is then totally ignored/stripped off internally.
,
Feb 8 2017
BTW This is a really low priority item, just noticed the problem when showing Jeff some stuff today and wanted to make sure we had the thought tracked somewhere.
,
Feb 8 2017
,
Feb 14 2017
CL out for review: https://codereview.chromium.org/2693953006/
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/07e9f35001395b3ce620471b4896c6fb29020330 commit 07e9f35001395b3ce620471b4896c6fb29020330 Author: jonesmi <jonesmi@google.com> Date: Thu Mar 23 22:49:12 2017 Isolate: Download files as their filename instead of hash BUG= 689728 R=maruel@chromium.org Review-Url: https://codereview.chromium.org/2693953006 [modify] https://crrev.com/07e9f35001395b3ce620471b4896c6fb29020330/appengine/components/components/template.py [modify] https://crrev.com/07e9f35001395b3ce620471b4896c6fb29020330/appengine/isolate/handlers_frontend.py [modify] https://crrev.com/07e9f35001395b3ce620471b4896c6fb29020330/appengine/isolate/handlers_test.py [modify] https://crrev.com/07e9f35001395b3ce620471b4896c6fb29020330/appengine/isolate/templates/browse.html [add] https://crrev.com/07e9f35001395b3ce620471b4896c6fb29020330/appengine/isolate/templates/isolated.html
,
Jun 7 2017
I think this CL is fixed? jonesmi@google.com can you confirm?
,
Jun 7 2017
Yes |
||||
►
Sign in to add a comment |
||||
Comment 1 by mar...@chromium.org
, Feb 7 2017