Dan, can this be a regression from https://codereview.chromium.org/2583743002? Please reassign the bug appropriately.

but wait, that's the OLD options page?  can you give a screenshot of the new one?

I swear I attached both pages... Here it is now.

Deleted: Screen Shot 2017-02-07 at 3.20.10 PM.png 56.8 KB

	Screen Shot 2017-02-07 at 3.20.10 PM.png 56.8 KB View Download

Alan: what should it look like when Chrome fails to update (i.e. if your internet's not working)?

Ping. Any update?

Can we reliably detect it's a network issue? If so, let's replace the primary-text with "There is no internet connection"

At this point, we need a way to expose all errors that come from the updater. Something like "Additional info" link that opens the full error message would be the best. My example with no network connection is just one of many errors that the updater may return. E.g. at the moment, the most common one is due to auto-updates running in the background. This is a short-term fix to help with diagnosing the issue either by the user or by support person.

In future, we plan to create a logic in Chrome that parses the raw messages from the updater and provides more meaningful information to the user.

Dan, I can look into this. This particular message is Chrome OS specific.

borisv@ - See issue 681901 for planned improvements to thies UI. Feel free to add comments there or create a separate feature request issue and link it.

For this issue I just plan to ensure parity with the existing UI.

FWIW, if the message is coming back from C++ in the already existing mechanism (a 'update-status-changed' WebUI event), it should be properly displayed in the UI, see https://bugs.chromium.org/p/chromium/issues/detail?id=689715#c9.

Oops, I meant to link to https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.js?q=about_page.js&sq=package:chromium&dr&l=278.

bettes@ -

The old UI shows one of two messages for the top line:

"You are currently offline." (no internet connection)
"You are currently connected to the mobile network." (was 'cellular')

And (depending on update preferences) either:

"To check for updates, please use Ethernet, Wi-Fi or mobile data."
"To check for updates, please use Ethernet or Wi-Fi."

We plan to improve this issue 681901, but for this I will make sure that show these messages unless I hear otherwise (e.g. I could replace the first one with "There is no internet connection" if you prefer)

I will also ensure that any message described in comment #12 is shown consistently with the current UI.

It turns out that we are simply not showing the second line in the new UI, fix is here:
https://codereview.chromium.org/2698133003/

Thanks for the quick fix, Steve. Can you attach a screenshot for how it would look like after the CR? The CR looks ok, but I wouldn't trust my limited knowledge of HTML/JS to make conclusions.

Thanks, Steve. What about update errors? Let us try to create an error:

1. Launch Chrome and go to the settings page.
2. Once the check is complete, run the command below:
$/Library/Google/GoogleSoftwareUpdate/GoogleSoftwareUpdate.bundle/Contents/MacOS/ksadmin -P com.google.Chrome.canary --delete
3. Refresh/reopen the settings page to check for updates again.

There should be an error that the ticket is missing (deleted in #2).

Or you may want to delete "com.google.Chrome" in #2 above, if this is the product that you have.

There is no logical difference between different types of update errors in the UI itself, the strings are provided by the same model that the old Settings UI uses. We were just missing the second piece of it (which I double checked and it is the only field we were ignoring).

Also, I do not have easy access to a Mac :P

Once this is in do please feel free to test this more thoroughly!

Sure, thank you, Steve. Again, I appreciate the fast fix. 

why are we showing 3 lines in a 2 line box?

What makes it a 2 line box? I understand your point, just saying that this particular UI needs to be flexible to display different error messages (that can span different number of lines, especially taking into account other languages).

correction: if it had the proper top/bottom spacing, it could be an N-line box, but our boxes aren't currently dealing with that well

I'll fix the padding.

Screenshots with and without the error:

Deleted: Screenshot 2017-02-17 at 10.29.08 AM.png 315 KB

	Screenshot 2017-02-17 at 10.29.08 AM.png 315 KB View Download

Deleted: Screenshot 2017-02-17 at 10.29.21 AM.png 323 KB

	Screenshot 2017-02-17 at 10.29.21 AM.png 323 KB View Download

Wrong screenshots, those were the old ones, here are the new ones:

Deleted: Screenshot 2017-02-17 at 10.11.06 AM.png 336 KB

	Screenshot 2017-02-17 at 10.11.06 AM.png 336 KB View Download

Deleted: Screenshot 2017-02-17 at 10.11.40 AM.png 339 KB

	Screenshot 2017-02-17 at 10.11.40 AM.png 339 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/875d1fb2901159381fb28c278148432c8da568b5

commit 875d1fb2901159381fb28c278148432c8da568b5
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Feb 21 20:08:35 2017

MD Settings: About: Show connectionTypes message

BUG= 689715 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2698133003
Cr-Commit-Position: refs/heads/master@{#451826}

[modify] https://crrev.com/875d1fb2901159381fb28c278148432c8da568b5/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/875d1fb2901159381fb28c278148432c8da568b5/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/875d1fb2901159381fb28c278148432c8da568b5/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/875d1fb2901159381fb28c278148432c8da568b5/chrome/test/data/webui/settings/about_page_tests.js

I just installed today's canary and the errors are still not shown in the UI. See the attached screenshot.
The build is "Version 58.0.3020.0 (Official Build) canary (64-bit)".
The commit from the change in comment #28 is in the build. See the list of changes here: https://chromium.googlesource.com/chromium/src/+log/58.0.3019.0..58.0.3020.0?pretty=fuller&n=10000

Deleted: Screen Shot 2017-02-22 at 9.36.36 AM.png 129 KB

	Screen Shot 2017-02-22 at 9.36.36 AM.png 129 KB View Download

borisv@ - Could you provide a repro? You seem to be in an unexpected state where it says 'Checking for updates' with an error icon. Also, can you check the JS console for any error messages?

Repro - cut the network (both wifi and wired).

And yes, there is a JS exception - see attached log. There are also a bunch of deprecation messages. 

Deleted: settings-1487789619230.log 2.1 KB

settings-1487789619230.log 2.1 KB View Download

Please be more precise in your repro. For example, here is the repro I have been using with a ToT official build:

1. Go to chrome://md-settings, click on 'About Chrome OS' in the the left side menu.
2. Disconnect or disable any network conenctions.
3. Click 'check for updates'.
4; Observe: see attached screenshot

Deleted: Screenshot 2017-02-22 at 12.10.35 PM.png 80.0 KB

	Screenshot 2017-02-22 at 12.10.35 PM.png 80.0 KB View Download

(The JS error by the way is almost certainly the problem here, but I have no idea how/why there are <br> elements in the error message, so I need to figure out how to reproduce this locally).

Yes, the assertion error seems to be thrown from https://cs.chromium.org/chromium/src/ui/webui/resources/js/parse_html_subset.js?l=61, because the error's HTML contains a <br> tag.

Re: comment #32/#32 - Also, what OS was the repro on? Error messages may be platform dependent.

Repro steps are in the bug description. Scroll to the top.
For repro steps regarding update errors, see comment #17.

OS-wise, I believe that I opened it for Mac, but the platform was later expanded in comment #5 to Windows and Linux too.

I am still seeing the original issue - no network, no error message on my Mac.

OK. As discussed offline, assigning to you dpapad@ to try to reproduce on Oscar and decide what to do about embedded <br> tags.

I was able to reproduce the error when there is not internet access. The error's HTML is the following

Update failed (error: 11)<br/><br/>Error details:<br/><pre>The Internet connection appears to be offline. [NSURLErrorDomain:-1009] (The Internet connection appears to be offline. [kCFErrorDomainCFNetwork:-1009])
KSServerUpdateRequest fetch failed. (productID: com.google.Chrome.canary) [com.google.UpdateEngine.CoreErrorDomain:702 - &#39;https://tools.google.com/service/update2?cup2hreq=58aab3e8662ed1e8e239ebecb45e66a6547d89806277498359e15a70013d7e93&amp;cup2key=6:4052306628&#39;] (The Internet connection appears to be offline. [NSURLErrorDomain:-1009])
The Internet connection appears to be offline. [NSURLErrorDomain:-1009] (The Internet connection appears to be offline. [kCFErrorDomainCFNetwork:-1009])
KSServerUpdateRequest fetch failed. (productID: com.google.Chrome.canary) [com.google.UpdateEngine.CoreErrorDomain:702 - &#39;http://tools.google.com/service/update2?cup2hreq=58aab3e8662ed1e8e239ebecb45e66a6547d89806277498359e15a70013d7e93&amp;cup2key=6:2803007023&#39;] (The Internet connection appears to be offline. [NSURLErrorDomain:-1009])
</pre>


The reason the error is not displayed properly is because we first run it through parseHtmlSubset (see [1]) for security reasons, which disallows <br> tags. The old Options apparently simply place the error's HTML in the document. The easy fix is to simply allow both <br> and <pre> in parseHtmLSubset().

@dbeam: WDYT?

[1] https://cs.chromium.org/chromium/src/ui/webui/resources/js/parse_html_subset.js?type=cs&q=parseHtmlSubset&sq=package:chromium&l=36

why does this stuff need to be in HTML again?

"why does this stuff need to be in HTML again?"
It doesn't, but needs to be escaped appropriately. Keystone likes to throw '<' and '>' in the error messages.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cafb071c30fe11e98598cbd1060165a8f4f22af

commit 7cafb071c30fe11e98598cbd1060165a8f4f22af
Author: dpapad <dpapad@chromium.org>
Date: Fri Feb 24 19:10:34 2017

MD Settings: About page, show error messages with <br> and <pre> tags.

BUG= 689715 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2714883002
Cr-Commit-Position: refs/heads/master@{#452894}

[modify] https://crrev.com/7cafb071c30fe11e98598cbd1060165a8f4f22af/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/7cafb071c30fe11e98598cbd1060165a8f4f22af/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/7cafb071c30fe11e98598cbd1060165a8f4f22af/chrome/test/data/webui/settings/about_page_tests.js

@borisv: This should be fixed now, and should look like this http://imgur.com/a/cYM8C. Closing. Please re-open if you find more error messages that don't get surfaced.

Perfect! Thank you for the quick fix, folks.

Verified in Canary build 58.0.3026.0