clean up/remove kmeans color extraction codepaths |
||
Issue descriptionThere are a few places that use CalculateKMeanColorOfBitmap and related functions. We're going to be porting the android palette color extraction API so this will replace existing uses of the kmean algorithm. But a lot of places seem not to actually need color extraction at all any more, so could just be removed.
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ade507ebc96b7ac8a1cfcf2f265e715174967567 commit ade507ebc96b7ac8a1cfcf2f265e715174967567 Author: estade <estade@chromium.org> Date: Wed Feb 08 16:08:51 2017 Remove unused function for extracting colors from a favicon on Android. BUG= 689704 Review-Url: https://codereview.chromium.org/2683853003 Cr-Commit-Position: refs/heads/master@{#449004} [modify] https://crrev.com/ade507ebc96b7ac8a1cfcf2f265e715174967567/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java [modify] https://crrev.com/ade507ebc96b7ac8a1cfcf2f265e715174967567/chrome/browser/android/favicon_helper.cc
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d00f7189cf554e07c0b25788266919725d90ffb9 commit d00f7189cf554e07c0b25788266919725d90ffb9 Author: estade <estade@chromium.org> Date: Thu Feb 23 18:50:17 2017 Port Android palette API for deriving a prominent color from an image. This code is not yet used but will soon be applied to coloration of the CrOS shelf and ripples based on the wallpaper. It may also be used to replace the KMeans algorithm that presently exists. See Android package android.support.v7.graphics https://developer.android.com/reference/android/support/v7/graphics/package-summary.html BUG=687852,595010, 689704 Review-Url: https://codereview.chromium.org/2690513002 Cr-Commit-Position: refs/heads/master@{#452564} [modify] https://crrev.com/d00f7189cf554e07c0b25788266919725d90ffb9/ui/gfx/color_analysis.cc [modify] https://crrev.com/d00f7189cf554e07c0b25788266919725d90ffb9/ui/gfx/color_analysis.h [modify] https://crrev.com/d00f7189cf554e07c0b25788266919725d90ffb9/ui/gfx/color_analysis_unittest.cc
,
Aug 28
pkasting found another place to use the kmeans algorithm in the theme engine, so I guess we'll keep it for now. |
||
►
Sign in to add a comment |
||
Comment 1 by est...@chromium.org
, Feb 8 2017