CrOS: migrate usage of deprecated base::Values API |
|||||||
Issue descriptionVarious base::Value API methods that consume/produce raw pointer have been deprecated, are being removed from chrome (see issue 581865), and will eventually be removed from libchrome. We should migrate CrOS code to use the unique_ptr equivalence of those deprecated APIs.
,
Feb 7 2017
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/update_engine/+/42458e2b6df997d0fcb5ccefb0cd3d40220143eb commit 42458e2b6df997d0fcb5ccefb0cd3d40220143eb Author: Ben Chan <benchan@chromium.org> Date: Wed Feb 08 06:27:06 2017 update_engine: migrate usage of deprecated base::Value methods Methods provided by base::Value that consume or produce unmanaged raw pointers have been deprecated and will be eventually removed from libchrome. This CL migrates the usage of these deprecated methods in the update-engine code to the equivalent methods that use std::unique_ptr. BUG= chromium:689697 TEST=Run unit tests. Change-Id: I6a1af33735c8114fd4600618f647d5adc0a89603 Reviewed-on: https://chromium-review.googlesource.com/438840 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/42458e2b6df997d0fcb5ccefb0cd3d40220143eb/update_manager/evaluation_context.cc
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/1c8c1f93cff10c5a9b6fe396b6d3b739c2380792 commit 1c8c1f93cff10c5a9b6fe396b6d3b739c2380792 Author: Ben Chan <benchan@chromium.org> Date: Wed Feb 08 06:27:05 2017 libbrillo: migrate usage of deprecated base::Value methods base::ListValue::DeepCopy() and base::DictionaryValue::DeepCopy() have been deprecated and will eventually be removed from libchrome. This CL migrates the usage of these deprecated methods in the libbrillo code to the equivalent base::ListValue::CreateDeepCopy() and base::DictionaryValue::CreateDeepCopy(). BUG= chromium:689697 TEST=Run unit tests. Change-Id: If8fa22c5830ffbd885d66bf63e7afaf662fd1ec3 Reviewed-on: https://chromium-review.googlesource.com/438798 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/1c8c1f93cff10c5a9b6fe396b6d3b739c2380792/brillo/value_conversion.cc
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/64bb93f73baf56c677157c7e8a469a75444a3d18 commit 64bb93f73baf56c677157c7e8a469a75444a3d18 Author: Ben Chan <benchan@chromium.org> Date: Thu Feb 09 00:24:29 2017 cryptohome: migrate usage of deprecated base::Value methods Methods provided by base::Value that consume or produce unmanaged raw pointers have been deprecated and will be eventually removed from libchrome. This CL migrates the usage of these deprecated methods in the cryptohome code to the equivalent methods that use std::unique_ptr. BUG= chromium:689697 TEST=Run unit tests. Change-Id: I9665c6b9eb6f6266447e21cd2ac076052f01ead6 Reviewed-on: https://chromium-review.googlesource.com/439410 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/64bb93f73baf56c677157c7e8a469a75444a3d18/cryptohome/mount.h [modify] https://crrev.com/64bb93f73baf56c677157c7e8a469a75444a3d18/cryptohome/install_attributes.cc [modify] https://crrev.com/64bb93f73baf56c677157c7e8a469a75444a3d18/cryptohome/mount.cc [modify] https://crrev.com/64bb93f73baf56c677157c7e8a469a75444a3d18/cryptohome/service.cc [modify] https://crrev.com/64bb93f73baf56c677157c7e8a469a75444a3d18/cryptohome/install_attributes.h
,
Feb 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/platform/actions/+/11c54d353c7d779113c983c33ea6e5090031025e commit 11c54d353c7d779113c983c33ea6e5090031025e Author: Ben Chan <benchan@chromium.org> Date: Thu Feb 09 04:31:52 2017
,
Feb 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/platform/actions/+/11c54d353c7d779113c983c33ea6e5090031025e commit 11c54d353c7d779113c983c33ea6e5090031025e Author: Ben Chan <benchan@chromium.org> Date: Thu Feb 09 04:31:52 2017
,
Feb 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/82d67a42bd48e67250f459e7aa88cdb033b3f4f7 commit 82d67a42bd48e67250f459e7aa88cdb033b3f4f7 Author: Ben Chan <benchan@chromium.org> Date: Thu Feb 09 04:31:47 2017
,
Feb 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/thermald/+/69360426cd06be989f1879bf37703ae3fc49d648 commit 69360426cd06be989f1879bf37703ae3fc49d648 Author: Ben Chan <benchan@chromium.org> Date: Thu Feb 09 04:31:56 2017
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e723398ca027d82737baad48295cbe7f3a8e44c4 commit e723398ca027d82737baad48295cbe7f3a8e44c4 Author: Ben Chan <benchan@chromium.org> Date: Thu Feb 09 09:18:29 2017 buffet: migrate usage of deprecated base::Value methods Methods provided by base::Value that consume or produce unmanaged raw pointers have been deprecated and will be eventually removed from libchrome. This CL migrates the usage of these deprecated methods in the buffet code to the equivalent methods that use std::unique_ptr. BUG= chromium:689697 TEST=Run unit tests. Change-Id: I64f056fdad945065caa64df54ba68d64e3b732cd Reviewed-on: https://chromium-review.googlesource.com/439724 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e723398ca027d82737baad48295cbe7f3a8e44c4/buffet/dbus_conversion_unittest.cc [modify] https://crrev.com/e723398ca027d82737baad48295cbe7f3a8e44c4/buffet/dbus_conversion.cc [modify] https://crrev.com/e723398ca027d82737baad48295cbe7f3a8e44c4/buffet/dbus_conversion.h [modify] https://crrev.com/e723398ca027d82737baad48295cbe7f3a8e44c4/buffet/manager.cc
,
Feb 9 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by benchan@chromium.org
, Feb 7 2017