New issue
Advanced search Search tips

Issue 689689 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update and/or verify that we can still create oscillator sweep test files.

Project Member Reported by rtoy@chromium.org, Feb 7 2017

Issue description

Near the top of https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js?q=oscillator-testing&l=1 there is some (commented-out) code on how to create a new reference file if needed.

Verify that this code still works and also look into the possibility of converting that not to use js-test.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5f830019d57e4405d74568dde8989b5cc7661c4

commit f5f830019d57e4405d74568dde8989b5cc7661c4
Author: rtoy <rtoy@chromium.org>
Date: Thu Feb 09 23:26:13 2017

Update code for generating osc sweep reference files

Update instruction and code on how to generate the reference files for
the oscillator sweep tests.

Manually extracted the code to its own file and ran the test to
generate a swept sine wave.  Output is generated and audibly sounds
correct.

BUG= 689689 
TEST=

Review-Url: https://codereview.chromium.org/2687953002
Cr-Commit-Position: refs/heads/master@{#449462}

[modify] https://crrev.com/f5f830019d57e4405d74568dde8989b5cc7661c4/third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js

Comment 2 by rtoy@chromium.org, Feb 10 2017

Owner: rtoy@chromium.org
Status: Verified (was: Available)

Sign in to add a comment