New issue
Advanced search Search tips

Issue 689673 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Make Custom Tabs better on low memory devices

Project Member Reported by lizeb@google.com, Feb 7 2017

Issue description

This is a tracking bug for low memory device specific optimizations for Custom Tabs.
 

Comment 1 by lizeb@chromium.org, Feb 7 2017

Components: UI>Browser>Mobile>CustomTabs
Labels: -Pri-3 Pri-2
Owner: lizeb@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bcd576d2621e7b20d8f3bf3f5c87914077ca39e

commit 9bcd576d2621e7b20d8f3bf3f5c87914077ca39e
Author: lizeb <lizeb@chromium.org>
Date: Thu Feb 16 11:03:37 2017

customtabs: Don't resurrect a "kept alive" process that died.

When the system is really low on memory, it can kill a process that
Chrome is trying to keep alive. Alternatively, the process can die. In
this case, don't resurrect the process, as it has likely lost all state.

BUG=689673

Review-Url: https://codereview.chromium.org/2679933004
Cr-Commit-Position: refs/heads/master@{#450929}

[modify] https://crrev.com/9bcd576d2621e7b20d8f3bf3f5c87914077ca39e/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java

Comment 3 Deleted

Comment 4 Deleted

Labels: -Hotlist-EM
Labels: EM
Labels: -EM LowMemory

Comment 8 by lizeb@chromium.org, Mar 3 2017

Testing on Android M, svelte:

Without ChromeLauncherActivity:

count     163.000000
mean     1218.325153
std       262.966643
min       871.000000
25%      1066.000000
50%      1132.000000
75%      1267.500000
max      2590.000000

With ChromeLauncherActivity:

count     149.000000
mean     1347.302013
std       301.930225
min       996.000000
25%      1157.000000
50%      1243.000000
75%      1456.000000
max      2879.000000


Comment 9 by pasko@chromium.org, Mar 6 2017

stats look good! Can you please throw raw data as well for future reference?
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5

commit c30689772f29d6ce17a1c2a992ca0f5d6c3eede5
Author: lizeb <lizeb@chromium.org>
Date: Tue Mar 07 17:20:12 2017

customtabs: Benchmark app for WebView / Custom Tabs comparisons.

One alternative to Custom Tabs is an in-app browser based on
WebView. This commit extends the Custom Tabs test app to allow direct
comparisons between WebView and Custom Tabs on devices.

The changes are:
- New WebViewActivity implementing a very basic WebView-based browser
- Added UI to test CCT vs WebView manually

BUG=689673

Review-Url: https://codereview.chromium.org/2722733004
Cr-Commit-Position: refs/heads/master@{#455110}

[modify] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/BUILD.gn
[modify] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/java/AndroidManifest.xml
[modify] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
[add] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/WebViewActivity.java
[add] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/res/layout/activity_web_view.xml
[add] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/res/layout/main.xml
[add] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/res/values/strings.xml
[modify] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py
[add] https://crrev.com/c30689772f29d6ce17a1c2a992ca0f5d6c3eede5/tools/android/customtabs_benchmark/scripts/launch.sh

Project Member

Comment 12 by sheriffbot@chromium.org, Jul 27 2017

Labels: Hotlist-Google

Sign in to add a comment