GetThreatSeverity() in v4_local_database_manager.cc does not handle CLIENT_INCIDENT |
||||||
Issue description
CLIENT_INCIDENT case is missing from this switch-case construct:
ThreatSeverity GetThreatSeverity(const ListIdentifier& list_id) {
switch (list_id.threat_type()) {
case MALWARE_THREAT:
case SOCIAL_ENGINEERING_PUBLIC:
case MALICIOUS_BINARY:
return 0;
case UNWANTED_SOFTWARE:
return 1;
case API_ABUSE:
return 2;
default:
NOTREACHED() << "Unexpected ThreatType encountered: "
<< list_id.threat_type();
return kLeastSeverity;
}
}
,
Feb 7 2017
This isn't landed yet but updating the bug to request merge. The change is trivial (addition of a case statement). CL (lgtm'd by one reviewer, waiting for one more review): https://codereview.chromium.org/2680163002/
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e2788493f4bef375b52e78e5a9ee38f2d92b191 commit 4e2788493f4bef375b52e78e5a9ee38f2d92b191 Author: vakh <vakh@chromium.org> Date: Wed Feb 08 03:11:54 2017 GetThreatSeverity should handle the case of CheckResourceUrl. Added the case statement and a unit test that forces a full hash match which causes this method to get executed. BUG= 689672 Review-Url: https://codereview.chromium.org/2680163002 Cr-Commit-Position: refs/heads/master@{#448885} [modify] https://crrev.com/4e2788493f4bef375b52e78e5a9ee38f2d92b191/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/4e2788493f4bef375b52e78e5a9ee38f2d92b191/components/safe_browsing_db/v4_local_database_manager_unittest.cc
,
Feb 8 2017
Please apply appropriate OS labels. Thank you.
,
Feb 8 2017
Please apply appropriate OS labels. Thank you.
,
Feb 8 2017
,
Feb 9 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2017
Please merge your change to M57 branch 2987 before 5:00 PM PT, Friday 02/10 so we can take it in for next week beta release. Thank you.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/840966737a17e664a34df6ebf816d534ece71d3e commit 840966737a17e664a34df6ebf816d534ece71d3e Author: vakh <vakh@chromium.org> Date: Thu Feb 09 22:57:28 2017 [M57] GetThreatSeverity should handle the case of CheckResourceUrl. Added the case statement and a unit test that forces a full hash match which causes this method to get executed. BUG= 689672 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2680163002 Cr-Commit-Position: refs/heads/master@{#448885} (cherry picked from commit 4e2788493f4bef375b52e78e5a9ee38f2d92b191) Review-Url: https://codereview.chromium.org/2679173006 Cr-Commit-Position: refs/branch-heads/2987@{#420} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/840966737a17e664a34df6ebf816d534ece71d3e/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/840966737a17e664a34df6ebf816d534ece71d3e/components/safe_browsing_db/v4_local_database_manager_unittest.cc
,
Feb 9 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vakh@chromium.org
, Feb 7 2017