New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689666 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

LLD fails to dead strip user32.dll dependencies from chrome_elf.dll

Project Member Reported by r...@chromium.org, Feb 7 2017

Issue description

This is why chrome_elf_unittests is failing on CrWinClangLLD tester.

If you build chrome with lld, build the "chrome_elf" target, and run dumpbin /dependents, you can see the difference.

Here are the MSVC-linker produced chrome_elf dependencies:
    KERNEL32.dll
    VERSION.dll

Vs. LLD:
    KERNEL32.dll
    USER32.dll
    VERSION.dll
    SHELL32.dll
    PSAPI.DLL
    ole32.dll
    WS2_32.dll

Most of the code in Chrome's //base library that depends on shell32, psapi, user32, etc is removed by MSVC's /OPT:REF implementation. LLD should do the same.
 

Comment 1 by ruiu@google.com, Feb 7 2017

Interesting. So I guess it contains empty import tables for all the DLLs except for KERNEL32 and VERSION?

Comment 2 by r...@chromium.org, Mar 22 2017

Labels: clang

Comment 3 by thakis@chromium.org, Apr 25 2017

Blocking: 82385

Comment 4 by thakis@chromium.org, Apr 25 2017

Rui, is this still on your radar?

Comment 5 by r...@chromium.org, May 12 2017

A user filed this as https://bugs.llvm.org/show_bug.cgi?id=32950

Comment 6 by ruiu@google.com, May 18 2017

Should be fixed in LLVM r303304 (which is a re-submission of r303304).

Comment 7 by ruiu@google.com, Jun 5 2017

Can someone close this? I believe it's fixed, but it seems I don't have a permission to close.

Comment 8 by r...@chromium.org, Jun 5 2017

Status: Verified (was: Untriaged)
Yep, here's a green build from June 4: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD%20tester/builds/1503

Thanks!

Sign in to add a comment