New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

When navigating from a page using MediaSession API to a page which is not, the actions persists

Project Member Reported by zqzh...@chromium.org, Feb 7 2017

Issue description

A follow up of  https://crbug.com/687973 
Sadly I didn't realized it in the beginning :(
 
Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 8 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15ab0ba733d50b9f7567bd77049aafeaa9114b0b

commit 15ab0ba733d50b9f7567bd77049aafeaa9114b0b
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Wed Feb 08 18:23:56 2017

[Media>UI] Reset media session actions when navigating away

There is a bug caused by media session actions being not properly reset
when navigating away, so that the notification control buttons stays the
same when the new page starts to play media. This CL fixes the issue.

BUG= 689664 

Review-Url: https://codereview.chromium.org/2680103002
Cr-Commit-Position: refs/heads/master@{#449032}
(cherry picked from commit e9c5df7d3be68ce0d8cf656dac0b9a1912ea5a28)

Review-Url: https://codereview.chromium.org/2685943002 .
Cr-Commit-Position: refs/branch-heads/2987@{#389}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/15ab0ba733d50b9f7567bd77049aafeaa9114b0b/chrome/android/BUILD.gn
[modify] https://crrev.com/15ab0ba733d50b9f7567bd77049aafeaa9114b0b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/15ab0ba733d50b9f7567bd77049aafeaa9114b0b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/15ab0ba733d50b9f7567bd77049aafeaa9114b0b/chrome/android/java_sources.gni
[add] https://crrev.com/15ab0ba733d50b9f7567bd77049aafeaa9114b0b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

Status: Fixed (was: Started)

Sign in to add a comment