Issue 689648 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ mka@chromium.org Last visit > 30 days ago
Closed:	Feb 2017
Cc:	derat@chromium.org snanda@chromium.org tbroch@chromium.org
Components:	OS>Kernel>Power
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
Arch-All VerifyIn-59 VerifyIn-60 VerifyIn-61

Blocking:
issue 214886

Use udev rule to enable WiFi power save mode statically

Project Member Reported by mka@chromium.org, Feb 7 2017

Issue description

Currently WiFi power save mode (PSM) is handled by laptop-mode-tools (LMT) which we intend to replace ( Issue 214886 ). Depending on the configuration LMT enables PSM always or only when the device runs on battery.

In the discussion on how to handle PSM in a post-LMT world the decision was taken to enable PSM always across all devices. The rationale is that users spend significant time running on battery, if PSM has problems they should be addressed. Further a static setting reduces the size of the test matrix. In case significant problems are encountered that can't be resolved immediately it is always an option to revert to the previous settings.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ea493f799c49e1dad8b73e01f04610bceb0d12d4

commit ea493f799c49e1dad8b73e01f04610bceb0d12d4
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Thu Feb 09 20:47:32 2017

laptop-mode-tools: Disable WiFi power management module

WiFi powersave mode is now enabled through a udev rule

BUG= chromium:214886 ,  chromium:689648 
TEST=build and install on gru/kevin (without CL:439884)
  boot DUT with power supply connected
  iw dev mlan0 set power_save off
  disconnect the power supply
  iw dev mlan0 get power_save
    => Power save: off
CQ-DEPEND=CL:439884

Change-Id: I9a286f218c188808f3fdd7c8f2e363b3bb4c089c
Reviewed-on: https://chromium-review.googlesource.com/439805
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[add] https://crrev.com/ea493f799c49e1dad8b73e01f04610bceb0d12d4/app-laptop/laptop-mode-tools/files/0036-disable-wireless-power-management.patch
[modify] https://crrev.com/ea493f799c49e1dad8b73e01f04610bceb0d12d4/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59.ebuild
[rename] https://crrev.com/ea493f799c49e1dad8b73e01f04610bceb0d12d4/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59-r41.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0d52752bf77dfd1e187e2c5b71ac44f3dce3e9b0

commit 0d52752bf77dfd1e187e2c5b71ac44f3dce3e9b0
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Thu Feb 09 20:47:33 2017

power: Add udev rule to enable WiFi power save mode

BUG= chromium:689648 ,  chromium:214886 
TEST=emerge-kevin power_manager
  boot DUT with power supply connected
  iw dev mlan0 get power_save
    => Power save: on
  iw dev mlan0 set power_save off
  disconnect the power supply
  udevadm trigger -c add --subsystem-match=net
  iw dev mlan0 get power_save
    => Power save: on
  iw dev mlan0 set power_save off
  connect the power supply
  udevadm trigger -c add --subsystem-match=net
  iw dev mlan0 get power_save
    => Power save: on
CQ-DEPEND=CL:439805

Change-Id: I2933f0169da84e7647848a73645b8784cd5998ad
Reviewed-on: https://chromium-review.googlesource.com/439884
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[add] https://crrev.com/0d52752bf77dfd1e187e2c5b71ac44f3dce3e9b0/power_manager/udev/99-powerknobs.rules