New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689638 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 692980
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Buildbucket Gerrit plugin displayed trybot results from a dfiferent change

Project Member Reported by rmis...@google.com, Feb 7 2017

Issue description


herb@ noticed that when he uploaded his change (https://skia-review.googlesource.com/c/8140/) and clicked on dry run it immediately displayed all bots green.

When I tried it on my machine I saw correct in-progress builds and that buildbucket plugin was hitting the right URL.
borenet@ and I checked herb@'s computer and saw the all green builds that he reported, and saw that buildbucket was for some reason displaying results from https://skia-review.googlesource.com/c/7786/9 instead of from 8140.

I have not been able to reproduce this yet but I am filing a high priority bug in-case there is an in-progress rollout of the buildbucket plugin right now with a bug in it.

 

Comment 1 by rmis...@google.com, Feb 7 2017

I do not see a roll in progress: https://cl-status.corp.google.com/#/dashboard/gerritcodereview

Noticed that https://skia-review.googlesource.com/c/7786/9 was also herb@'s CL. Maybe something was cached by the plugin that displayed incorrect results on a different change?

Comment 2 Deleted

Comment 3 by no...@chromium.org, Feb 7 2017

Cc: andyb...@chromium.org
there was no recent deployments on cr-buildbucket.appspot.com https://screenshot.googleplex.com/cDjyhLpWUWz

+Andy, any deployments of polygerrit?
Labels: Milestone-Dogfood Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
Yep. There appears to be have been a deployment.

Comment 5 by herb@google.com, Feb 9 2017

This has happened again.

I was looking at a CL/8230. Used the 'u' key to go to my list if changes,
switched to CL/ 8272 and the trybots from CL/8230 showed up.

Comment 6 by no...@chromium.org, Feb 9 2017

next time it happens, please do
1) open Developer Tools' Network tab
2) Type "buildbucket" in the Filter textbox
2) Wait. Page refreshes builds every 5s
3) Look for a new request to buidbucket, copy its data over here. In particular, I am interested in :path request header. It could look like this:

:path:/_ah/api/buildbucket/v1/search?max_builds=500&fields=builds(failure_reason%2Cid%2Cparameters_json%2Cresult%2Cstatus%2Ctags%2Curl)&tag=buildset%3Apatch%2Fgerrit%2Fchromium-review.googlesource.com%2F439809%2F1

this one requests for builds for CL https://chromium-review.googlesource.com/c/439809/ (which is correct in my case), as indicated by 
  tag=buildset%3Apatch%2Fgerrit%2Fchromium-review.googlesource.com%2F439809%2F1
Cc: jcgrego...@google.com

Comment 8 by bore...@google.com, Mar 20 2017

This is occurring for me on https://skia-review.googlesource.com/c/9888/.  I see jobs for PS1 associated with PS2.

Two requests:

:path:/_ah/api/buildbucket/v1/search?max_builds=500&fields=builds(failure_reason%2Cid%2Cparameters_json%2Cresult%2Cstatus%2Ctags%2Curl)&tag=buildset%3Apatch%2Fgerrit%2Fskia-review.googlesource.com%2F9888%2F2
200

:path:/_ah/api/buildbucket/v1/search?max_builds=500&fields=builds(failure_reason%2Cid%2Cparameters_json%2Cresult%2Cstatus%2Ctags%2Curl)&tag=buildset%3Apatch%2Fgerrit%2Fskia-review.googlesource.com%2F9888%2F2
401

Comment 9 by aga...@chromium.org, Mar 27 2017

Mergedinto: 692980
Status: Duplicate (was: Assigned)
Even though this is the older bug, duping into the one with more information

Sign in to add a comment