Measure actual usage of deprecated quota API methods |
||
Issue descriptionThe current use counters for Quota APIs are: PrefixedStorageInfo - measures window.webkitStorageInfo PrefixedStorageQuota - measures navigator.webkitTemporaryStorage and navigator.webkitPermanentStorage The numbers look crazy high for these. Since these just look at property access the histograms are easily ticked by enumeration. We should measure the usage of the actual methods: DeprecatedStorageQuota.queryUsageAndQuota DeprecatedStorageQuota.requestQuota DeprecatedStorageInfo.queryUsageAndQuota DeprecatedStorageInfo.requestQuota
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2d99c3aed47c0f159676a1fbf496e530be25885 commit b2d99c3aed47c0f159676a1fbf496e530be25885 Author: jsbell <jsbell@chromium.org> Date: Fri Feb 10 19:25:53 2017 Add detailed use-counter stats for the prefixed quota APIs The "legacy" prefixed quota APIs have ridiculously high usage counts: The oldest one window.webkitStorageInfo tracked as PrefixedStorageInfo has 0.07% of page loads which is crazy high... But navigator.webkitTemporaryStorage/webkitTemporaryStorage tracked together as as PrefixedStorageQuota have 0.8% of page loads! The counters exist on the attributes gating access, rather than the methods themselves, so they might be getting overcounted due to simple enumeration of the window/navigator objects. This change adds per-method counters that will show actual usage of the APIs so we can better plan out a deprecation strategy. BUG= 689601 R=mpearson@chromium.org,foolip@chromium.org Review-Url: https://codereview.chromium.org/2683333002 Cr-Commit-Position: refs/heads/master@{#449685} [modify] https://crrev.com/b2d99c3aed47c0f159676a1fbf496e530be25885/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/b2d99c3aed47c0f159676a1fbf496e530be25885/third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.idl [modify] https://crrev.com/b2d99c3aed47c0f159676a1fbf496e530be25885/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.idl [modify] https://crrev.com/b2d99c3aed47c0f159676a1fbf496e530be25885/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/b2d99c3aed47c0f159676a1fbf496e530be25885/tools/metrics/histograms/update_use_counter_feature_enum.py
,
Feb 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by jsb...@chromium.org
, Feb 10 2017