In WebInputMethodController::setComposition, replace |selectionStart| and |selectionEnd| with WebRange |
||
Issue descriptionIn WebInputMethodController::setComposition, replace |selectionStart| and |selectionEnd| with WebRange.
,
Nov 8 2017
Taking a second look at this bug I suppose this should be a Won't Fix. blink::WebRange considers any range with either |start_ == -1| or |end_ == -1| as invalid. On the other hand, we do allow negative valued selection{Start, End}, e.g., PTAL |WebViewTest.SetCompositionForNewCaretPositions|.
That being said we might be able to still use WebRange to hold both negative values but that voids the meaning of WebRange::IsNull(). So I guess we should not proceed with this refactoring.
Supposedly a SelectionRange struct which would allow negative start and end and even start > end would be the right choice here.
Please undo the status change if you believe we should do more.
|
||
►
Sign in to add a comment |
||
Comment 1 by ekaramad@chromium.org
, Feb 7 2017