Issue metadata
Sign in to add a comment
|
separator in website settings popup no longer extends all the way to the edge |
||||||||||||||||||||||||
Issue descriptionin 56, it goes all the way to the edge. in 58, it doesn't. I suspect crrev.com/57b697aa2605b6bbcb97352a32ccdb28204739e9
,
Feb 9 2017
before, after, and a pixel diff (Harmony) https://codereview.chromium.org/2686983002
,
Feb 9 2017
Here is Win/non-harmony before/after. Note the dialog gets slightly narrower, which is a closer match to the m56 version as well.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c commit 3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c Author: tapted <tapted@chromium.org> Date: Thu Feb 09 06:17:10 2017 Ensure the line on the origin info bubble extends the full width of the bubble. This regressed in r444474 which was necessary to adapt the bubble margins to support Harmony layout (i.e. since margins are no longer a compile-time constant). The separator line, however, needs to ignore the margins completely. So move the bubble margin into the classes doing layout above and below the separator. BUG= 689574 Review-Url: https://codereview.chromium.org/2686983002 Cr-Commit-Position: refs/heads/master@{#449222} [modify] https://crrev.com/3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc [modify] https://crrev.com/3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
,
Feb 10 2017
,
Feb 12 2017
Verified fixed in Version 58.0.3010.0 canary, requesting merge of r449222 to m-57
,
Feb 12 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39df7ec4a3cf18ffd93ac26ab1472d5031f4b9d5 commit 39df7ec4a3cf18ffd93ac26ab1472d5031f4b9d5 Author: Trent Apted <tapted@chromium.org> Date: Sun Feb 12 22:52:20 2017 [merge-m57] Ensure the line on the origin info bubble extends the full width of the bubble. This regressed in r444474 which was necessary to adapt the bubble margins to support Harmony layout (i.e. since margins are no longer a compile-time constant). The separator line, however, needs to ignore the margins completely. So move the bubble margin into the classes doing layout above and below the separator. BUG= 689574 Review-Url: https://codereview.chromium.org/2686983002 Cr-Commit-Position: refs/heads/master@{#449222} (cherry picked from commit 3b76fcf9516aed2d90a61ae035cfdf2b2a18e08c) Review-Url: https://codereview.chromium.org/2692773002 . Cr-Commit-Position: refs/branch-heads/2987@{#467} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/39df7ec4a3cf18ffd93ac26ab1472d5031f4b9d5/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc [modify] https://crrev.com/39df7ec4a3cf18ffd93ac26ab1472d5031f4b9d5/chrome/browser/ui/views/website_settings/website_settings_popup_view.h
,
Feb 12 2017
,
Feb 15 2017
Verified this issue on Ubuntu 14.04 and Windows-10 using chrome latest M57-57.0.2987.54. By clicking on secure lock icon from the omnibox observed the dialog gets narrower as expected. Hence adding TE-Verified label.
,
Apr 27 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Feb 8 2017