New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689559 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 685244



Sign in to add a comment

clang-tot-device bot failing runhooks

Project Member Reported by thakis@chromium.org, Feb 7 2017

Issue description

started here: https://uberchromegw.corp.google.com/i/internal.bling.fyi/builders/clang-tot-device/builds/517

________ running '/usr/bin/python src/ios/build/tools/setup-gn.py --import src/ios_internal/build/args.gn' in '/b/build/slave/clang-tot-device/build'
ERROR at //build/config/compiler/BUILD.gn:103:7: Script returned non-zero exit code.
      exec_script("//tools/clang/scripts/update.py", update_args, "trim string")
      ^----------
Current dir: /b/build/slave/clang-tot-device/build/src/out/_tempSX7tE_/
Command: python -- /b/build/slave/clang-tot-device/build/src/tools/clang/scripts/update.py --print-revision
Returned 1.
stderr:

svn: E155007: '/b/build/slave/clang-tot-device/build/src/third_party/llvm' is not a working copy
Traceback (most recent call last):
  File "/b/build/slave/clang-tot-device/build/src/tools/clang/scripts/update.py", line 920, in <module>
    sys.exit(main())
  File "/b/build/slave/clang-tot-device/build/src/tools/clang/scripts/update.py", line 891, in main
    print GetSvnRevision(LLVM_DIR)
  File "/b/build/slave/clang-tot-device/build/src/tools/clang/scripts/update.py", line 170, in GetSvnRevision
    svn_info = subprocess.check_output('svn info ' + svn_repo, shell=True)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command 'svn info /b/build/slave/clang-tot-device/build/src/third_party/llvm' returned non-zero exit status 1

See //build/config/BUILDCONFIG.gn:472:3: which caused the file to be included.
  "//build/config/compiler:afdo",
  ^-----------------------------


I think the problem is that the setup-gn hook runs before the update_clang hook, which in tot builds checks out third_party/llvm.


sdefresne, iirc you did setup-gn -- can you take a look?
 
Cc: justincohen@chromium.org
justincohen apparently touched it too and is maybe in a better timezone
Cc: rohitrao@chromium.org
Owner: sdefresne@chromium.org
Status: Started (was: Untriaged)
Since src/ is fetched via DEPS by src/ios_internal/DEPS, all hooks in src/ios_internal/DEPS are run before any hooks from src/DEPS. AFAICT, there is no way to have the hook run last, so we have to duplicate the src/DEPS hooks into src/ios_internal/DEPS.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c259d34517b7f1f25ca4e09bc689ebc33d687fe0

commit c259d34517b7f1f25ca4e09bc689ebc33d687fe0
Author: sdefresne <sdefresne@google.com>
Date: Tue Feb 07 18:26:37 2017

Status: Fixed (was: Started)
I think the issue is fixed though the following build failed due to missing "ld". Is this because the bots do not have Xcode installed and thus cannot build?

Sign in to add a comment