New issue
Advanced search Search tips

Issue 689527 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 654861



Sign in to add a comment

Add a counter for hover:on-demand

Project Member Reported by mustaq@chromium.org, Feb 7 2017

Issue description

We need to assess the risk of dropping the support for this particular media query value. The spec no longer mentions this.
 
Labels: -Pri-3 M-57 ReleaseBlock-Beta Pri-2
Status: Fixed (was: Assigned)
This is a meta bug for merging the counter to M-57. The change has been committed, see  Issue 654861 #c11.
Labels: Merge-Request-57
Status: Verified (was: Fixed)
Verified that the counter works in win64 canary (58.0.3005.2).
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 8 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6546a71226670e46e4745b09ee96a697887fd4be

commit 6546a71226670e46e4745b09ee96a697887fd4be
Author: Mustaq Ahmed <mustaq@google.com>
Date: Wed Feb 08 16:35:52 2017

Added a UseCounter for hover:on-demand media query parsing.

BUG= 654861 , 689527 
TBR=rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2678933002
Cr-Commit-Position: refs/heads/master@{#448407}
(cherry picked from commit 324495d3549f08062867c366e4ed2f23d83d78bb)

Review-Url: https://codereview.chromium.org/2682073004 .
Cr-Commit-Position: refs/branch-heads/2987@{#388}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/6546a71226670e46e4745b09ee96a697887fd4be/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/6546a71226670e46e4745b09ee96a697887fd4be/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/6546a71226670e46e4745b09ee96a697887fd4be/tools/metrics/histograms/histograms.xml

Sign in to add a comment