New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689507 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in ui::MenuModel::GetModelAndIndexForCommandId

Project Member Reported by ClusterFuzz, Feb 7 2017

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6483884129910784

Fuzzer: attekett_surku_fuzzer
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6110057abbc0
Crash State:
  ui::MenuModel::GetModelAndIndexForCommandId
  views::MenuModelAdapter::IsCommandVisible
  views::MenuItemView::AddMenuItemAt
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=448465:448526

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95E_TT0dhxqPTXj1LqUPvzPIivsZoOBoos8xT8mHMr2rSYt-jFd63_CNeRkQ1y7qnFqkMiRZTLIzRki6_0fCOOYbGPbWL_sJe3XSL9REOjeDIzc-tfJ5Eftp5A26ZnSCpbIP31FEAuj9I23FK1Azqb03HHV0OubcQoopuVyRjn5cgunsuuuePWUrcSeYZzJCjhnkan7Qvl5z2dABI1R6bKqZB0I3VTC0EuwwBD7AhtLtQyW3k3CqvYWM57OYCr8VSDuRf_Kja_BC8oCY5sT4lmtn3AqFXptLmmUvnm9MoysuVN9CqxNUHK_cGu1GkuTH-hHLiHOlPBQxdjb3IEINHOQlTKB9gEUntv0JWAikb7k42OySpdjaHVDYcXftQRDIu55qSqWdTHWTMZODOek4gEVi_do_w?testcase_id=6483884129910784


Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 7 2017

Labels: M-58
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 7 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 7 2017

Labels: Pri-1
Components: Internals>Views
Labels: OS-Mac
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
spqchan@, could you take a look at this issue if it is caused by your cl https://codereview.chromium.org/2164483006? 

Thanks!
Project Member

Comment 5 by ClusterFuzz, Feb 11 2017

ClusterFuzz has detected this issue as fixed in range 449634:449646.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6483884129910784

Fuzzer: attekett_surku_fuzzer
Job Type: linux_asan_chrome_media
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6110057abbc0
Crash State:
  ui::MenuModel::GetModelAndIndexForCommandId
  views::MenuModelAdapter::IsCommandVisible
  views::MenuItemView::AddMenuItemAt
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=448465:448526
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_media&range=449634:449646

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95E_TT0dhxqPTXj1LqUPvzPIivsZoOBoos8xT8mHMr2rSYt-jFd63_CNeRkQ1y7qnFqkMiRZTLIzRki6_0fCOOYbGPbWL_sJe3XSL9REOjeDIzc-tfJ5Eftp5A26ZnSCpbIP31FEAuj9I23FK1Azqb03HHV0OubcQoopuVyRjn5cgunsuuuePWUrcSeYZzJCjhnkan7Qvl5z2dABI1R6bKqZB0I3VTC0EuwwBD7AhtLtQyW3k3CqvYWM57OYCr8VSDuRf_Kja_BC8oCY5sT4lmtn3AqFXptLmmUvnm9MoysuVN9CqxNUHK_cGu1GkuTH-hHLiHOlPBQxdjb3IEINHOQlTKB9gEUntv0JWAikb7k42OySpdjaHVDYcXftQRDIu55qSqWdTHWTMZODOek4gEVi_do_w?testcase_id=6483884129910784


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Feb 11 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6483884129910784 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 11 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
Labels: -ReleaseBlock-Beta
Project Member

Comment 10 by sheriffbot@chromium.org, May 20 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment