New issue
Advanced search Search tips

Issue 689505 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Add unittests for the ReadingListCollectionViewItem presented data

Project Member Reported by olivierrobin@chromium.org, Feb 7 2017

Issue description

Add test to check that presented data match the mocks

- The title as text
- The formatted URL as detail text
- The distilled URL as source for the favicon
- The distillation status for the badge.

If the entry is not processed, use the URL for the favicon.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a5bf0558cc1d567ee88a145e9095dcb22adfcb

commit 22a5bf0558cc1d567ee88a145e9095dcb22adfcb
Author: olivierrobin <olivierrobin@chromium.org>
Date: Wed Feb 08 10:12:22 2017

[ReadingList] Unittests on ReadingListCollectionViewItem presented data.

Add unittests to check that data presented in the
ReadingListViewController is the correct one.

- The title as text
- The formatted URL as detail text
- The distilled URL as source for the favicon
- The distillation status for the badge.

If the entry is not processed, use the URL for the favicon.

BUG= 689505 

Review-Url: https://codereview.chromium.org/2682683002
Cr-Commit-Position: refs/heads/master@{#448942}

[modify] https://crrev.com/22a5bf0558cc1d567ee88a145e9095dcb22adfcb/ios/chrome/browser/ui/reading_list/BUILD.gn
[modify] https://crrev.com/22a5bf0558cc1d567ee88a145e9095dcb22adfcb/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment