New issue
Advanced search Search tips

Issue 689501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689499

Blocking:
issue 680924


Show other hotlists

Hotlists containing this issue:
NFC


Sign in to add a comment

Move //device/nfc to be part of the internal impl of the Device Service

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

It should move to //services/device/nfc and be visible in GN only to //services/device.
 
Status: Available (was: Untriaged)
Components: Blink>NFC

Comment 3 by leon....@intel.com, May 21 2017

Owner: leon....@intel.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4

commit 02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4
Author: leon.han <leon.han@intel.com>
Date: Tue May 23 06:33:33 2017

Move //device/nfc to be part of the internal impl of Device Service

BUG= 689501 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2894373002
Cr-Commit-Position: refs/heads/master@{#473822}

[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/browser/BUILD.gn
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/browser/android/nfc_host.cc
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/browser/android/nfc_host.h
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/public/android/BUILD.gn
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/public/android/DEPS
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/content/test/BUILD.gn
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/device/BUILD.gn
[delete] https://crrev.com/561da39a7a22b9d1ff96fcc742bd32bc2c3543b6/device/nfc/BUILD.gn
[delete] https://crrev.com/561da39a7a22b9d1ff96fcc742bd32bc2c3543b6/device/nfc/OWNERS
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/BUILD.gn
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/BUILD.gn
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/device_service.cc
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/device_service.h
[add] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/OWNERS
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/BUILD.gn
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/InvalidNfcMessageException.java
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcImpl.java
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcMessageValidator.java
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcProviderImpl.java
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcTagHandler.java
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/NfcTypeConverter.java
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/java/src/org/chromium/device/nfc/OWNERS
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/nfc/android/junit/src/org/chromium/device/nfc/NFCTest.java
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/public/interfaces/nfc.mojom
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/public/interfaces/nfc_provider.mojom
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/public/java/BUILD.gn
[rename] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/services/device/public/java/src/org/chromium/device/nfc/NfcDelegate.java
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/third_party/WebKit/Source/modules/nfc/BUILD.gn
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/third_party/WebKit/Source/modules/nfc/DEPS
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/third_party/WebKit/Source/modules/nfc/NFC.h
[modify] https://crrev.com/02ed4aebda2b2da70a2c32a7b2b92c67c8c01dd4/third_party/WebKit/Source/modules/nfc/NFCError.h

Comment 5 by leon....@intel.com, May 25 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment