New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689450 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Disposing the isolate that is entered by a thread in wasm-call.cc

Project Member Reported by ClusterFuzz, Feb 7 2017

Issue description

Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong
Owner: ahaas@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner who worked on wasm-call.cc.
@ahaas -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by ahaas@chromium.org, Feb 8 2017

Status: Started (was: Assigned)

Comment 3 by ahaas@chromium.org, Feb 16 2017

Cc: ahaas@chromium.org
 Issue 690397  has been merged into this issue.

Comment 4 by ahaas@chromium.org, Feb 16 2017

 Issue 689121  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5f1661aad71b22028a9e2cedcae0e913ec338946

commit 5f1661aad71b22028a9e2cedcae0e913ec338946
Author: Andreas Haas <ahaas@chromium.org>
Date: Thu Feb 16 12:09:32 2017

[turbofan] For Word32Shl optimizations only consider the last 5 bits of the shift

One optimization in the machine-operator-reducer did not consider that
that word32 shift left instructions only consider the last 5 bits of
the shift input.

The issue only occurs for WebAssembly because in JavaScript we always
add a "& 0xf" on the shift value to the TurboFan graph.

For additional background: The JavaScript and WebAssembly spec both
say that only the last 5 bits of the shift value are used in the
word32-shift-left operation. This means that an "x << 0x29", in the
code is actually executed as "x << 0x09". Therefore the changes in
this CL are okay because they mask the last 5 bit of the shift value.

BUG= chromium:689450 

Change-Id: Id92f298ed6d7f1714b109b3f4fbcecd5ac6d30f7
Reviewed-on: https://chromium-review.googlesource.com/439312
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43245}
[modify] https://crrev.com/5f1661aad71b22028a9e2cedcae0e913ec338946/src/compiler/machine-operator-reducer.cc
[add] https://crrev.com/5f1661aad71b22028a9e2cedcae0e913ec338946/test/mjsunit/regress/wasm/regression-689450.js

Project Member

Comment 6 by ClusterFuzz, Feb 17 2017

Project Member

Comment 7 by ClusterFuzz, Feb 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4906796163792896 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment