New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689437 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 773463

Blocking:
issue 612328



Sign in to add a comment

Device Service: Move //device/vr to other location(s) in the codebase

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

Blocked on adding the ability to mock service connectors in JS for layout tests (see blocking bug).

Note that the interface should have a TODO referencing  crbug.com/680518  to make clear that the hosted interface won't do anything useful unless the embedder of the Device Service has injected the needed dependencies into the VR impl via C++.

As part of this work, the Mojo interface should be moved into //services/device/public/interfaces.
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by ke...@intel.com, May 19 2017

There is a CL in pending:
https://codereview.chromium.org/2603553002/

Comment 4 by ke...@intel.com, May 19 2017

Cc: blundell@chromium.org

Comment 5 by ke...@intel.com, Jul 7 2017

Owner: ----
Status: Available (was: Started)
Blockedon: -689385
Blocking: -612342 612328
Cc: amp@chromium.org mthiesse@chromium.org bshe@chromium.org billorr@chromium.org
Labels: -Pri-2 Pri-3
Summary: Device Service: Move //device/vr to other location(s) in the codebase (was: Move VR Mojo interface from being hosted in //content/browser to being hosted in the Device Service)
Updating based on our new understanding that VR will not end up in the Device Service but rather in a distinct service. Thus, servicification of VR is not a blocker for the Device Service. However, we *do* need to eliminate //device/vr as part of eliminating //device. My proposal based on various discussions:

- Move the Mojo interfaces into Blink so that both Blink and //chrome can access them
- Move all of the C++ code into //chrome (presumably //chrome/browser/vr, although perhaps //device/vr/android should go somewhere else, e.g. //chrome/browser/android/vr_shell).

VR folks, does that sound feasible?
Cc: bajones@chromium.org
It'll be interesting to figure out how we want to wire up the gamepads :/
re: c#7, I commented on the Gamepad bug raising this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=612330#c43.
Components: Internals>Services>Device
Blockedon: 773463
Per input from bajones@, there is a tentative plan to eliminate VR's dependence on Gamepad, but the timeframe is not clear (see blocking bug).
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 11

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment