New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689433 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : File list appears blank on pressing Ctrl+P keys in 'Sources' under devtools.

Reported by yfulgaon...@etouch.net, Feb 7 2017

Issue description

Chrome Version : 58.0.3004.4 (Official Build) 54ca43feba44b861ed9986bb7d3b65d7178edd41-refs/branch-heads/3004@{#5} 32/64 bit
OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://flash and open devtools.
2. In devtools, navigate to 'Sources' tab and press 'Ctrl + P' to open a file list.
3. Observe the file list.

Actual : File list appears blank on pressing Ctrl+P keys in 'Sources' under devtools.
Expected : File list should not appear blank, instead list should show all the file names after pressing Ctrl+P.

This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info.
Good build : 58.0.2999.0
Bad build : 58.0.3000.0

Note : Above issue is also reproducible on other internal pages like 'chrome://invalidations' and 'chrome://inspect'.
 
Actual_devtools.mp4
1.7 MB View Download
Expected_devtools.mp4
1.3 MB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.2999.0 (Revision: 447413).
Bad build: 58.0.3000.0 (Revision: 447669).

You are probably looking for a change made after 447668 (known good), but no later than 447669 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/09a6a441c91c5a52650c315cc915fe461e58cb33..ed1f2fac6209f8d2e0db3f7dcff38d1e69f5db26

From the CL above, assigning the issue to the concern owner

@dgozman:Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2658383002

Note : 1.Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.2.
2.Able to reproduce in latest Canary #58.0.3004.3
3.Adding Release Block-Stable for this issue.Please remove if not the case.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733d09b5b7c0edd6e59d10e9e9d7a7fd81ab3509

commit 733d09b5b7c0edd6e59d10e9e9d7a7fd81ab3509
Author: dgozman <dgozman@chromium.org>
Date: Tue Feb 14 21:24:06 2017

[DevTools] Always issue resize on viewport in FilteredListWidget.

Due to recent changes in GlassPane and setFixedHeight, checking
dialog element's height does not work anymore.

BUG= 689433 

Review-Url: https://codereview.chromium.org/2693033002
Cr-Commit-Position: refs/heads/master@{#450479}

[modify] https://crrev.com/733d09b5b7c0edd6e59d10e9e9d7a7fd81ab3509/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[modify] https://crrev.com/733d09b5b7c0edd6e59d10e9e9d7a7fd81ab3509/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Status: Fixed (was: Assigned)
Labels: TE-Verified-M58 TE-Verified-58.0.3013.3
Tested the issue on Windows-7, Mac-10.12.2 and Linux Ubuntu-14.04 using 58.0.3013.3 as per the comment#0.

Observed that the fix is working as expected.

Attaching screen cast for reference .

Hence,adding the verified labels.

Thanks.
689433.mov
9.5 MB Download

Sign in to add a comment