New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 689429 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 689410
issue 689428

Blocking:
issue 702449
issue 612346



Sign in to add a comment

Consolidate //device/{power_save_blocker, wake_lock} inside Device Service

Project Member Reported by blundell@chromium.org, Feb 7 2017

Issue description

Once the Wake Lock Mojo interface is hosted by the Device Service and the only usage of //device/power_save_blocker is within the Wake Lock implementation, these two implementations should be consolidated into //services/device as the internal implementation of the Wake Lock Mojo interface. Concretely, both directories should move into //services/device/wake_lock, which should be made visible in GN only to //services/device.
 

Comment 1 by derat@chromium.org, Mar 17 2017

Blocking: 702449

Comment 2 by ke...@intel.com, Jul 6 2017

Owner: ke...@intel.com
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4e26b4c700ffeb98db0bc856f205251777d134c

commit e4e26b4c700ffeb98db0bc856f205251777d134c
Author: Ke He <ke.he@intel.com>
Date: Fri Jul 07 05:15:08 2017

Move WakeLock to be part of the internal implementation of Device Service.

This CL moves wake lock from //device into //services/device, updates all wake
lock clients' BUILD.gn and DEPS.

To avoid make this CL too big, The PowerSaveBlocker was left alone in
//device. In next CL we'll move the //device/power_save_blocker into //services
and make it visiable in GN only to //services/device.

BUG= 689429 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ic50dfb3284995919d3f58d656b12ca649a8d17e9
Reviewed-on: https://chromium-review.googlesource.com/554950
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484837}
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/chromeos/drive/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/media/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/media/cast_transport_host_filter.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/renderer_host/pepper/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/sync_file_system/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/ui/webui/chromeos/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/components/drive/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/components/drive/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/components/drive/drive_uploader.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/components/drive/drive_uploader.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/components/drive/job_scheduler.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/download/download_request_core.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/download/download_request_core.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/download/drag_download_file_browsertest.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/loader/wake_lock_resource_throttle.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/loader/wake_lock_resource_throttle.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/media/capture/aura_window_capture_machine.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/media/capture/aura_window_capture_machine.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/wake_lock/wake_lock_context_host.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/wake_lock/wake_lock_context_host.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/webrtc/webrtc_internals.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/browser/webrtc/webrtc_internals.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/public/browser/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/public/browser/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/content/test/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/device/BUILD.gn
[delete] https://crrev.com/8ba4cfa3d3beed403d349394e8569905381a21aa/device/wake_lock/OWNERS
[delete] https://crrev.com/8ba4cfa3d3beed403d349394e8569905381a21aa/device/wake_lock/public/interfaces/BUILD.gn
[delete] https://crrev.com/8ba4cfa3d3beed403d349394e8569905381a21aa/device/wake_lock/public/interfaces/OWNERS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/api/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/api/power/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/api/power/power_api.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/api/power/power_api.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/extensions/browser/api/power/power_api_unittest.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/device_service.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/device_service.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/public/interfaces/BUILD.gn
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/public/interfaces/README(WakeLock).md
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/public/interfaces/wake_lock.mojom
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/public/interfaces/wake_lock_context.mojom
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/public/interfaces/wake_lock_provider.mojom
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/BUILD.gn
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/DEPS
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock.cc
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock.h
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_context.cc
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_context.h
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_for_testing.cc
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_for_testing.h
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_provider.cc
[rename] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_provider.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/services/device/wake_lock/wake_lock_unittest.cc
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/third_party/WebKit/Source/modules/wake_lock/BUILD.gn
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/third_party/WebKit/Source/modules/wake_lock/DEPS
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h
[modify] https://crrev.com/e4e26b4c700ffeb98db0bc856f205251777d134c/third_party/WebKit/Source/web/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad4bdd490dc8477da2c82f7a31dc78c22295208a

commit ad4bdd490dc8477da2c82f7a31dc78c22295208a
Author: Ke He <ke.he@intel.com>
Date: Thu Jul 13 01:48:19 2017

Consolidate PowerSaveBlocker and WakeLock inside Device Service.

After all the clients have been converted to use wake lock mojom interfaces,
the power_save_blocker should be hidden inside Device Service.

One exception is //remoting which is the only client that still directly uses
the power save blocker instead of wake lock mojo interfaces. The  crbug.com/689423 
records the reason.

BUG= 689429 

Change-Id: I485369f1d7b3984ecaabb667b15562702cc9b5b1
Reviewed-on: https://chromium-review.googlesource.com/563159
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#486212}
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/content/app/BUILD.gn
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/content/app/DEPS
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/content/browser/DEPS
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/content/browser/OWNERS
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/content/public/android/BUILD.gn
[delete] https://crrev.com/c3ce41201ac0ccaea2e9bf1efeae55907184b10d/device/power_save_blocker/power_save_blocker_android.h
[delete] https://crrev.com/c3ce41201ac0ccaea2e9bf1efeae55907184b10d/device/power_save_blocker/power_save_blocker_export.h
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/remoting/host/BUILD.gn
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/remoting/host/DEPS
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/remoting/host/host_power_save_blocker.h
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/remoting/host/win/BUILD.gn
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/BUILD.gn
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/BUILD.gn
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/DEPS
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/BUILD.gn
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/DEPS
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/OWNERS
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/android/java/src/org/chromium/device/power_save_blocker/PowerSaveBlocker.java
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker.h
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker_android.cc
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker_chromeos.cc
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker_mac.cc
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker_ozone.cc
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker_win.cc
[rename] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/power_save_blocker/power_save_blocker_x11.cc
[modify] https://crrev.com/ad4bdd490dc8477da2c82f7a31dc78c22295208a/services/device/wake_lock/wake_lock.h

Comment 5 by leon....@intel.com, Jul 14 2017

Status: Fixed (was: Started)
Components: Internals>Services>Device

Sign in to add a comment