Convert //remoting from using PowerSaveBlocker to using Wake Lock Mojo interface |
||||||
Issue descriptionSee parent bug. Note that there's a question here: In the context in which //remoting runs, is a connection to the Service Manager available?
,
Mar 1 2017
,
Jun 26 2017
Hi, Colin, I found inside //remoting it cannot get the service manager. From the link: https://chromium.googlesource.com/chromium/src/+/lkgr/docs/old_chromoting_build_instructions.md I found The HostPowerSaveBlocker runs in a separate process(the GN target "remoting_me2me_host" is an "executable" type). It is built and packaged in a separate application(they call it "host service" in the above *.md). So its process is not child-process of BrowserProcess. So I guess it is not a part of Chrome, we shouldn't create the service manager connection to it. We can add the "visibility" in //Services/ and allow it to use power-save-blocker directly. WDYT? Thanks!
,
Jun 27 2017
,
Jul 4 2017
Final decision after discussion: So far no need to embed the Service Manager in //remoting, especially given that the only concrete use case right now is for Wake Lock. we'll allow //services/device/wake_lock to be visible in GN to //remoting and directly used by it with a comment saying that //remoting is outside of the context of a ServiceManager-based world.
,
Jul 7 2017
,
Nov 7 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by blundell@chromium.org
, Feb 7 2017